linux-stable.git/drivers/char/ipmi, branch v6.2.4

ipmi:ssif: Add a timer between request retries

2023-03-10T08:29:23+00:00

commit 00bb7e763ec9f384cb382455cb6ba5588b5375cf upstream.

The IPMI spec has a time (T6) specified between request retries.  Add
the handling for that.

Reported by: Tony Camuso 
Cc: stable@vger.kernel.org
Signed-off-by: Corey Minyard 
Signed-off-by: Greg Kroah-Hartman

ipmi_ssif: Rename idle state and check

2023-03-10T08:29:23+00:00

commit 8230831c43a328c2be6d28c65d3f77e14c59986b upstream.

Rename the SSIF_IDLE() to IS_SSIF_IDLE(), since that is more clear, and
rename SSIF_NORMAL to SSIF_IDLE, since that's more accurate.

Cc: stable@vger.kernel.org
Signed-off-by: Corey Minyard 
Signed-off-by: Greg Kroah-Hartman

ipmi:ssif: resend_msg() cannot fail

2023-03-10T08:29:23+00:00

commit 95767ed78a181d5404202627499f9cde56053b96 upstream.

The resend_msg() function cannot fail, but there was error handling
around using it.  Rework the handling of the error, and fix the out of
retries debug reporting that was wrong around this, too.

Cc: stable@vger.kernel.org
Signed-off-by: Corey Minyard 
Signed-off-by: Greg Kroah-Hartman

ipmi: ipmb: Fix the MODULE_PARM_DESC associated to 'retry_time_ms'

2023-03-10T08:29:23+00:00

commit befb28f2676a65a5a4cc4626ae224461d8785af6 upstream.

'This should be 'retry_time_ms' instead of 'max_retries'.

Fixes: 63c4eb347164 ("ipmi:ipmb: Add initial support for IPMI over IPMB")
Signed-off-by: Christophe JAILLET 
Message-Id: <0d8670cff2c656e99a832a249e77dc90578f67de.1675591429.git.christophe.jaillet@wanadoo.fr>
Cc: stable@vger.kernel.org
Signed-off-by: Corey Minyard 
Signed-off-by: Greg Kroah-Hartman

ipmi/watchdog: use strscpy() to instead of strncpy()

2022-12-05T12:50:09+00:00

Xu Panda 

The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.

Signed-off-by: Xu Panda 
Signed-off-by: Yang Yang 
Message-Id: <202212051936400309332@zte.com.cn>
Signed-off-by: Corey Minyard

ipmi: ssif_bmc: Convert to i2c's .probe_new()

2022-11-21T12:59:41+00:00

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König 
Message-Id: <20221118224540.619276-606-uwe@kleine-koenig.org>
Signed-off-by: Corey Minyard

ipmi: fix use after free in _ipmi_destroy_user()

2022-11-15T14:14:29+00:00

The intf_free() function frees the "intf" pointer so we cannot
dereference it again on the next line.

Fixes: cbb79863fc31 ("ipmi: Don't allow device module unload when in use")
Signed-off-by: Dan Carpenter 
Message-Id: 
Cc:  # 5.5+
Signed-off-by: Corey Minyard

ipmi/watchdog: Include when appropriate

2022-11-05T17:42:46+00:00

The kstrto() functions have been moved from kernel.h to
kstrtox.h.

So, in order to eventually remove  from ,
include the latter directly in the appropriate files.

Signed-off-by: Christophe JAILLET 
Message-Id: <37daa028845d90ee77f1e547121a051a983fec2e.1667647002.git.christophe.jaillet@wanadoo.fr>
Signed-off-by: Corey Minyard

ipmi:ssif: Increase the message retry time

2022-11-04T02:13:51+00:00

The spec states that the minimum message retry time is 60ms, but it was
set to 20ms.  Correct it.

Reported by: Tony Camuso 
Signed-off-by: Corey Minyard

ipmi: Fix some kernel-doc warnings

2022-10-25T11:45:26+00:00

The current code provokes some kernel-doc warnings:
	drivers/char/ipmi/ipmi_msghandler.c:618: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

Signed-off-by: Bo Liu 
Message-Id: <20221025060436.4372-1-liubo03@inspur.com>
Signed-off-by: Corey Minyard