linux-stable.git/drivers/char/ipmi, branch linux-4.17.y

ipmi: kcs_bmc: fix IRQ exception if the channel is not open

2018-08-24T11:06:49+00:00

[ Upstream commit dc0f0a026d33819bb82d5c26ab2fca838e2004be ]

When kcs_bmc_handle_event calls kcs_force_abort function to handle the
not open (no user running) KCS channel transaction, the returned status
value -ENODEV causes the low level IRQ handler indicating that the irq
was not for him by returning IRQ_NONE. After some time, this IRQ will
be treated to be spurious one, and the exception dump happens.

   irq 30: nobody cared (try booting with the "irqpoll" option)
   CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.10.15-npcm750 #1
   Hardware name: NPCMX50 Chip family
   [] (unwind_backtrace) from [] (show_stack+0x20/0x24)
   [] (show_stack) from [] (dump_stack+0x8c/0xa0)
   [] (dump_stack) from [] (__report_bad_irq+0x3c/0xdc)
   [] (__report_bad_irq) from [] (note_interrupt+0x29c/0x2ec)
   [] (note_interrupt) from [] (handle_irq_event_percpu+0x5c/0x68)
   [] (handle_irq_event_percpu) from [] (handle_irq_event+0x48/0x6c)
   [] (handle_irq_event) from [] (handle_fasteoi_irq+0xc8/0x198)
   [] (handle_fasteoi_irq) from [] (__handle_domain_irq+0x90/0xe8)
   [] (__handle_domain_irq) from [] (gic_handle_irq+0x58/0x9c)
   [] (gic_handle_irq) from [] (__irq_svc+0x6c/0x90)
   Exception stack(0xc0a01de8 to 0xc0a01e30)
   1de0:                   00002080 c0a6fbc0 00000000 00000000 00000000 c096d294
   1e00: 00000000 00000001 dc406400 f03ff100 00000082 c0a01e94 c0a6fbc0 c0a01e38
   1e20: 00200102 c01015bc 60000113 ffffffff
   [] (__irq_svc) from [] (__do_softirq+0xbc/0x358)
   [] (__do_softirq) from [] (irq_exit+0xb8/0xec)
   [] (irq_exit) from [] (__handle_domain_irq+0x94/0xe8)
   [] (__handle_domain_irq) from [] (gic_handle_irq+0x58/0x9c)
   [] (gic_handle_irq) from [] (__irq_svc+0x6c/0x90)
   Exception stack(0xc0a01ef8 to 0xc0a01f40)
   1ee0:                                                       00000000 000003ae
   1f00: dcc0f338 c0111060 c0a00000 c0a0cc44 c0a0cbe4 c0a1c22b c07bc218 00000001
   1f20: dcffca40 c0a01f54 c0a01f58 c0a01f48 c0103524 c0103528 60000013 ffffffff
   [] (__irq_svc) from [] (arch_cpu_idle+0x48/0x4c)
   [] (arch_cpu_idle) from [] (default_idle_call+0x30/0x3c)
   [] (default_idle_call) from [] (do_idle+0xc8/0x134)
   [] (do_idle) from [] (cpu_startup_entry+0x28/0x2c)
   [] (cpu_startup_entry) from [] (rest_init+0x84/0x88)
   [] (rest_init) from [] (start_kernel+0x388/0x394)
   [] (start_kernel) from [<0000807c>] (0x807c)
   handlers:
   [] npcm7xx_kcs_irq
   Disabling IRQ #30

It needs to change the returned status from -ENODEV to 0. The -ENODEV
was originally used to tell the low level IRQ handler that no user was
running, but not consider the IRQ handling desgin.

And multiple KCS channels share one IRQ handler, it needs to check the
IBF flag before doing force abort. If the IBF is set, after handling,
return 0 to low level IRQ handler to indicate that the IRQ is handled.

Signed-off-by: Haiyue Wang 
Signed-off-by: Corey Minyard 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

ipmi:bt: Set the timeout before doing a capabilities check

2018-07-03T09:26:49+00:00

commit fe50a7d0393a552e4539da2d31261a59d6415950 upstream.

There was one place where the timeout value for an operation was
not being set, if a capabilities request was done from idle.  Move
the timeout value setting to before where that change might be
requested.

IMHO the cause here is the invisible returns in the macros.  Maybe
that's a job for later, though.

Reported-by: Nordmark Claes 
Signed-off-by: Corey Minyard 
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman

ipmi/parisc: Add IPMI chassis poweroff for certain HP PA-RISC and IA-64 servers

2018-03-27T16:04:17+00:00

This patch allows HP PA-RISC servers like rp3410/rp3440 and the HP C8000
workstation with an IPMI controller that predate IPMI 1.5 to use the standard
poweroff or powercycle commands.

These systems firmware don't set the chassis capability bit in the Get
Device ID, but they do implement the standard poweroff and powercycle
commands.

Signed-off-by: Helge Deller 
Signed-off-by: Corey Minyard

ipmi_ssif: Fix kernel panic at msg_done_handler

2018-03-13T12:12:26+00:00

This happens when BMC doesn't return any data and the code is trying
to print the value of data[2].

Getting following crash:
[  484.728410] Unable to handle kernel NULL pointer dereference at virtual address 00000002
[  484.736496] pgd = ffff0000094a2000
[  484.739885] [00000002] *pgd=00000047fcffe003, *pud=00000047fcffd003, *pmd=0000000000000000
[  484.748158] Internal error: Oops: 96000005 [#1] SMP
[...]
[  485.101451] Call trace:
[...]
[  485.188473] [] msg_done_handler+0x668/0x700 [ipmi_ssif]
[  485.195249] [] ipmi_ssif_thread+0x110/0x128 [ipmi_ssif]
[  485.202038] [] kthread+0x108/0x138
[  485.206994] [] ret_from_fork+0x10/0x30
[  485.212294] Code: aa1903e1 aa1803e0 b900227f 95fef6a5 (39400aa3)

Adding a check to validate the data len before printing data[2] to fix this issue.

Signed-off-by: Kamlakant Patel 
Signed-off-by: Corey Minyard

ipmi:pci: Blacklist a Realtek "IPMI" device

2018-03-13T11:58:47+00:00

Realtek has some sort of "Virtual" IPMI device on the PCI bus as a
KCS controller, but whatever it is, it's not one.  Ignore it if seen.

Reported-by: Chris Chiu 
Signed-off-by: Corey Minyard 
Tested-by: Daniel Drake

ipmi: Remove ACPI SPMI probing from the system interface driver

2018-03-12T12:03:06+00:00

The IPMI spec states:

  The purpose of the SPMI Table is to provide a mechanism that can
  be used by the OSPM (an ACPI term for “OS Operating System-directed
  configuration and Power Management” essentially meaning an ACPI-aware
  OS or OS loader) very early in the boot process, e.g., before the
  ability to execute ACPI control methods in the OS is available.

When we are probing IPMI in Linux, ACPI control methods are available,
so we shouldn't be probing using SPMI.  It could cause some confusion
during the probing process.

Signed-off-by: Corey Minyard

ipmi: Remove ACPI SPMI probing from the SSIF (I2C) driver

2018-03-12T12:02:47+00:00

The IPMI spec states:

  The purpose of the SPMI Table is to provide a mechanism that can
  be used by the OSPM (an ACPI term for “OS Operating System-directed
  configuration and Power Management” essentially meaning an ACPI-aware
  OS or OS loader) very early in the boot process, e.g., before the
  ability to execute ACPI control methods in the OS is available.

When we are probing IPMI in Linux, ACPI control methods are available,
so we shouldn't be probing using SPMI.  It could cause some confusion
during the probing process.

Signed-off-by: Corey Minyard 
Tested-by: Jiandi An

ipmi: missing error code in try_smi_init()

2018-03-07T01:47:52+00:00

If platform_device_alloc() then we should return -ENOMEM instead of
returning success.

Signed-off-by: Dan Carpenter 
Signed-off-by: Corey Minyard

ipmi: use ARRAY_SIZE for poweroff_functions array sizing calculation

2018-03-07T01:47:51+00:00

Use the ARRAY_SIZE macro on a array poweroff_functions to determine
size of the array. Improvement suggested by Coccinelle.

Signed-off-by: Colin Ian King 
Signed-off-by: Corey Minyard

ipmi: Consolidate cleanup code

2018-03-07T01:47:50+00:00

The cleanup code for an init failure and for a device removal were
quite similar, consolidate all that into one function.

Signed-off-by: Corey Minyard