linux-stable.git/drivers/char/ipmi, branch linux-2.6.32.y

ipmi: move timer init to before irq is setup

2016-01-29T21:12:48+00:00

commit 27f972d3e00b50639deb4cc1392afaeb08d3cecc upstream.

We encountered a panic on boot in ipmi_si on a dell per320 due to an
uninitialized timer as follows.

static int smi_start_processing(void       *send_info,
                                ipmi_smi_t intf)
{
        /* Try to claim any interrupts. */
        if (new_smi->irq_setup)
                new_smi->irq_setup(new_smi);

 --> IRQ arrives here and irq handler tries to modify uninitialized timer

    which triggers BUG_ON(!timer->function) in __mod_timer().

 Call Trace:
   
   [] start_new_msg+0x47/0x80 [ipmi_si]
   [] start_check_enables+0x4e/0x60 [ipmi_si]
   [] smi_event_handler+0x1e8/0x640 [ipmi_si]
   [] ? __rcu_process_callbacks+0x54/0x350
   [] si_irq_handler+0x3c/0x60 [ipmi_si]
   [] handle_IRQ_event+0x60/0x170
   [] handle_edge_irq+0xde/0x180
   [] handle_irq+0x49/0xa0
   [] do_IRQ+0x6c/0xf0
   [] ret_from_intr+0x0/0x11

        /* Set up the timer that drives the interface. */
        setup_timer(&new_smi->si_timer, smi_timeout, (long)new_smi);

The following patch fixes the problem.

To: Openipmi-developer@lists.sourceforge.net
To: Corey Minyard 
CC: linux-kernel@vger.kernel.org

Signed-off-by: Jan Stancek 
Signed-off-by: Tony Camuso 
Signed-off-by: Corey Minyard 
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings 
(cherry picked from commit 207ffa8cbcf6e780d862316a94c95a7e70d1e72e)
Signed-off-by: Willy Tarreau

drivers/char/ipmi: memcpy, need additional 2 bytes to avoid memory overflow

2013-06-10T09:42:41+00:00

commit a5f2b3d6a738e7d4180012fe7b541172f8c8dcea upstream.

When calling memcpy, read_data and write_data need additional 2 bytes.

  write_data:
    for checking:  "if (size > IPMI_MAX_MSG_LENGTH)"
    for operating: "memcpy(bt->write_data + 3, data + 1, size - 1)"

  read_data:
    for checking:  "if (msg_len < 3 || msg_len > IPMI_MAX_MSG_LENGTH)"
    for operating: "memcpy(data + 2, bt->read_data + 4, msg_len - 2)"

Signed-off-by: Chen Gang 
Signed-off-by: Corey Minyard 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Willy Tarreau

ipmi: handle run_to_completion properly in deliver_recv_msg()

2010-07-05T18:10:57+00:00

commit a747c5abc329611220f16df0bb4cf0ca4a7fdf0c upstream.

If run_to_completion flag is set, it means that we are running in a
single-threaded mode, and thus no locks are held.

This fixes a deadlock when IPMI notifier is being called during panic.

Signed-off-by: Jiri Kosina 
Acked-by: Corey Minyard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

headers: remove sched.h from poll.h

2009-10-04T22:05:10+00:00

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Linus Torvalds

trivial: add init macro/ fix of exit macro location in ipmi_poweroff.c

2009-09-21T13:14:58+00:00

Trivial patch which adds the __init to the module_init function of
drivers/char/ipmi/ipmy_poweroff.c and corrects the location of __exit for the
cleanup function.

Signed-off-by: Peter Huewe 
Acked-by: Corey Minyard 
Signed-off-by: Jiri Kosina

ipmi: remove driver_data direct access of struct device

2009-06-16T04:30:27+00:00

In the near future, the driver core is going to not allow direct access
to the driver_data pointer in struct device.  Instead, the functions
dev_get_drvdata() and dev_set_drvdata() should be used.  These functions
have been around since the beginning, so are backwards compatible with
all older kernel versions.

Cc: openipmi-developer@lists.sourceforge.net
Acked-by: Corey Minyard 
Signed-off-by: Greg Kroah-Hartman

ipmi: fix ipmi_si modprobe hang

2009-05-22T14:30:41+00:00

Instead of queuing IPMB messages before channel initialization, just
throw them away.  Nobody will be listening for them at this point,
anyway, and they will clog up the queue and nothing will be delivered
if we queue them.

Also set the current channel to the number of channels, as this value
is used to tell if the channel information has been initialized.

Signed-off-by: Corey Minyard 
Cc: Ferenc Wagner 
Cc: Dan Frazier 
Signed-off-by: Linus Torvalds

ipmi: add oem message handling

2009-04-21T20:41:48+00:00

Enable userspace to receive messages that a BMC transmits using an OEM
medium.  This is used by the HP iLO2.

Based on code originally written by Patrick Schoeller.

Signed-off-by: dann frazier 
Signed-off-by: Corey Minyard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipmi: fix statistics counting issues

2009-04-21T20:41:48+00:00

Bela Lubkin noticed that the statistics for send IPMB and LAN commands
in the IPMI driver could be incremented even if an error occurred.  Move
the increments to the proper place to avoid this.

Also add some statistics for retransmissions that failed, and some little
helper functions to neaten up the code a little.

Signed-off-by: Corey Minyard 
Cc: Bela Lubkin 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipmi: test for event buffer before using

2009-04-21T20:41:48+00:00

The IPMI driver would attempt to use the event buffer even if that
didn't exist on the BMC.  This patch modified the IPMI driver to check
for the event buffer's existence before trying to use it.

Signed-off-by: Corey Minyard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

linux-stable.git/drivers/char/ipmi, branch linux-2.6.32.y

ipmi: move timer init to before irq is setup

drivers/char/ipmi: memcpy, need additional 2 bytes to avoid memory overflow

ipmi: handle run_to_completion properly in deliver_recv_msg()

headers: remove sched.h from poll.h

trivial: add __init macro/ fix of __exit macro location in ipmi_poweroff.c

ipmi: remove driver_data direct access of struct device

ipmi: fix ipmi_si modprobe hang

ipmi: add oem message handling

ipmi: fix statistics counting issues

ipmi: test for event buffer before using

trivial: add init macro/ fix of exit macro location in ipmi_poweroff.c