linux-stable.git/drivers/char/ipmi/ipmi_si_platform.c, branch linux-5.3.y

Merge tag 'for-linus-5.3' of git://github.com/cminyard/linux-ipmi

2019-07-13T22:07:02+00:00

Pull IPMI updates from Corey Minyard:
 "Some small fixes for various things, nothing huge, mostly found by
  automated tools.

  Plus add a driver that allows Linux to act as an IPMB slave device, so
  it can be a satellite MC in an IPMI network"

* tag 'for-linus-5.3' of git://github.com/cminyard/linux-ipmi:
  docs: ipmb: place it at driver-api and convert to ReST
  fix platform_no_drv_owner.cocci warnings
  ipmi: ipmb: don't allocate i2c_client on stack
  ipmi: ipmb: Fix build error while CONFIG_I2C is set to m
  Add support for IPMB driver
  drivers: ipmi: Drop device reference
  ipmi_ssif: fix unexpected driver unregister warning
  ipmi_si: use bool type for initialized variable
  ipmi_si: fix unexpected driver unregister warning

bus_find_device: Unify the match callback with class_find_device

2019-06-24T03:22:31+00:00

There is an arbitrary difference between the prototypes of
bus_find_device() and class_find_device() preventing their callers
from passing the same pair of data and match() arguments to both of
them, which is the const qualifier used in the prototype of
class_find_device().  If that qualifier is also used in the
bus_find_device() prototype, it will be possible to pass the same
match() callback function to both bus_find_device() and
class_find_device(), which will allow some optimizations to be made in
order to avoid code duplication going forward.  Also with that, constify
the "data" parameter as it is passed as a const to the match function.

For this reason, change the prototype of bus_find_device() to match
the prototype of class_find_device() and adjust its callers to use the
const qualifier in accordance with the new prototype of it.

Cc: Alexander Shishkin 
Cc: Andrew Lunn 
Cc: Andreas Noever 
Cc: Arnd Bergmann 
Cc: Bjorn Helgaas 
Cc: Corey Minyard 
Cc: Christian Borntraeger 
Cc: David Kershner 
Cc: "David S. Miller" 
Cc: David Airlie 
Cc: Felipe Balbi 
Cc: Frank Rowand 
Cc: Grygorii Strashko 
Cc: Harald Freudenberger 
Cc: Hartmut Knaack 
Cc: Heiko Stuebner 
Cc: Jason Gunthorpe 
Cc: Jonathan Cameron 
Cc: "James E.J. Bottomley" 
Cc: Len Brown 
Cc: Mark Brown 
Cc: Michael Ellerman 
Cc: Michael Jamet 
Cc: "Martin K. Petersen" 
Cc: Peter Oberparleiter 
Cc: Sebastian Ott 
Cc: Srinivas Kandagatla 
Cc: Yehezkel Bernat 
Cc: rafael@kernel.org
Acked-by: Corey Minyard 
Acked-by: David Kershner 
Acked-by: Mark Brown 
Acked-by: Rafael J. Wysocki 
Acked-by: Srinivas Kandagatla 
Acked-by: Wolfram Sang  # for the I2C parts
Acked-by: Rob Herring 
Signed-off-by: Suzuki K Poulose 
Signed-off-by: Greg Kroah-Hartman

drivers: ipmi: Drop device reference

2019-06-03T20:02:11+00:00

Drop the reference to a device found via bus_find_device()

Cc: Corey Minyard 
Cc: Arnd Bergmann 
Cc: Greg Kroah-Hartman 
Signed-off-by: Suzuki K Poulose 
Message-Id: <1559577023-558-3-git-send-email-suzuki.poulose@arm.com>
[Moved the put_device() to after the platform_device_unregister(), for
 better style.]
Signed-off-by: Corey Minyard

ipmi_si: fix unexpected driver unregister warning

2019-05-20T11:51:10+00:00

If ipmi_si_platform_init()->platform_driver_register() fails,
platform_driver_unregister() called unconditionally will trigger
following warning,

ipmi_platform: Unable to register driver: -12
------------[ cut here ]------------
Unexpected driver unregister!
WARNING: CPU: 1 PID: 7210 at drivers/base/driver.c:193 driver_unregister+0x60/0x70 drivers/base/driver.c:193

Fix it by adding platform_registered variable, only unregister platform
driver when it is already successfully registered.

Reported-by: Hulk Robot 
Signed-off-by: Kefeng Wang 
Message-Id: <20190517101245.4341-1-wangkefeng.wang@huawei.com>

Signed-off-by: Corey Minyard

ipmi: Remove warning if no slave address is present

2019-04-24T17:29:24+00:00

It's just noise, really, lots of systems don't have it.

Reported-by: Kamlakant Patel 
Signed-off-by: Corey Minyard

ipmi_si: Consolidate scanning the platform bus

2019-02-22T13:12:41+00:00

The same basic code was in two places.

Signed-off-by: Corey Minyard

ipmi_si: Switch hotmod to use a platform device

2019-02-22T13:12:41+00:00

Don't force the main code to create one for it.

Signed-off-by: Corey Minyard

ipmi: Consolidate the adding of platform devices

2019-02-22T13:12:41+00:00

It was being done in two different places now that hard-coded devices
use platform devices, and it's about to be three with hotmod switching
to platform devices.  So put the code in one place.

This required some rework on some interfaces to make the type space
clean.

Signed-off-by: Corey Minyard

ipmi_si: Rename addr_type to addr_space to match what it does

2019-02-22T13:12:41+00:00

Make the naming consistent, and make the values an enum.

Signed-off-by: Corey Minyard

ipmi_si: Fix crash when using hard-coded device

2019-02-22T13:12:41+00:00

When excuting a command like:
  modprobe ipmi_si ports=0xffc0e3 type=bt
The system would get an oops.

The trouble here is that ipmi_si_hardcode_find_bmc() is called before
ipmi_si_platform_init(), but initialization of the hard-coded device
creates an IPMI platform device, which won't be initialized yet.

The real trouble is that hard-coded devices aren't created with
any device, and the fixup is done later.  So do it right, create the
hard-coded devices as normal platform devices.

This required adding some new resource types to the IPMI platform
code for passing information required by the hard-coded device
and adding some code to remove the hard-coded platform devices
on module removal.

To enforce the "hard-coded devices passed by the user take priority
over firmware devices" rule, some special code was added to check
and see if a hard-coded device already exists.

Reported-by: Yang Yingliang 
Cc: stable@vger.kernel.org # v4.15+
Signed-off-by: Corey Minyard 
Tested-by: Yang Yingliang