linux-stable.git/drivers/char/ipmi/ipmi_si_platform.c, branch linux-5.0.y

ipmi_si: Fix crash when using hard-coded device

2019-03-23T19:11:34+00:00

commit 41b766d661bf94a364960862cfc248a78313dbd3 upstream.

When excuting a command like:
  modprobe ipmi_si ports=0xffc0e3 type=bt
The system would get an oops.

The trouble here is that ipmi_si_hardcode_find_bmc() is called before
ipmi_si_platform_init(), but initialization of the hard-coded device
creates an IPMI platform device, which won't be initialized yet.

The real trouble is that hard-coded devices aren't created with
any device, and the fixup is done later.  So do it right, create the
hard-coded devices as normal platform devices.

This required adding some new resource types to the IPMI platform
code for passing information required by the hard-coded device
and adding some code to remove the hard-coded platform devices
on module removal.

To enforce the "hard-coded devices passed by the user take priority
over firmware devices" rule, some special code was added to check
and see if a hard-coded device already exists.

Reported-by: Yang Yingliang 
Cc: stable@vger.kernel.org # v4.15+
Signed-off-by: Corey Minyard 
Tested-by: Yang Yingliang 
Signed-off-by: Greg Kroah-Hartman

ipmi: Remove platform driver overrides and use the id_table

2018-09-18T21:15:33+00:00

The IPMI DMI code was adding platform overrides, which is not
really an ideal solution.  Switch to using the id_table in
the drivers to identify the devices.

Signed-off-by: Corey Minyard

ipmi: Use more common logging styles

2018-09-18T21:15:33+00:00

Add and use #define pr_fmt/dev_fmt, and remove #define PFX

This also prefixes some messages that were not previously prefixed.

Miscellanea:

o Convert printk(KERN_ to pr_(
o Use %s, __func__ where appropriate

Signed-off-by: Joe Perches 
Signed-off-by: Corey Minyard

ipmi: Remove ACPI SPMI probing from the system interface driver

2018-03-12T12:03:06+00:00

The IPMI spec states:

  The purpose of the SPMI Table is to provide a mechanism that can
  be used by the OSPM (an ACPI term for “OS Operating System-directed
  configuration and Power Management” essentially meaning an ACPI-aware
  OS or OS loader) very early in the boot process, e.g., before the
  ability to execute ACPI control methods in the OS is available.

When we are probing IPMI in Linux, ACPI control methods are available,
so we shouldn't be probing using SPMI.  It could cause some confusion
during the probing process.

Signed-off-by: Corey Minyard

ipmi: Add or fix SPDX-License-Identifier in all files

2018-02-27T13:42:51+00:00

And get rid of the license text that is no longer necessary.

Signed-off-by: Corey Minyard 
Cc: Kees Cook 
Cc: Alistair Popple 
Cc: Jeremy Kerr 
Cc: Joel Stanley 
Cc: Rocky Craig

ipmi_si_platform: Fix typo in parameter description

2017-12-12T13:00:01+00:00

Fix typo in parameter description.

Fixes: 95e300c052fd ("ipmi: Make the DMI probe into a generic platform probe")
Signed-off-by: Wei Yongjun 
Signed-off-by: Corey Minyard

ipmi: Make the DMI probe into a generic platform probe

2017-09-28T17:26:03+00:00

Rework the DMI probe function to be a generic platform probe, and
then rework the DMI code (and a few other things) to use the more
generic information.  This is so other things can declare platform
IPMI devices.

Signed-off-by: Corey Minyard

ipmi_si: Move platform device handling to another file

2017-09-28T17:24:42+00:00

Signed-off-by: Corey Minyard 

Stephen Rothwell  fixed an issue with the
include files