linux-stable.git/drivers/char/ipmi/ipmi_si_hardcode.c, branch linux-5.0.y

ipmi: ipmi_si_hardcode.c: init si_type array to fix a crash

2019-05-16T17:40:20+00:00

[ Upstream commit a885bcfd152f97b25005298ab2d6b741aed9b49c ]

The intended behavior of function ipmi_hardcode_init_one() is to default
to kcs interface when no type argument is presented when initializing
ipmi with hard coded addresses.

However, the array of char pointers allocated on the stack by function
ipmi_hardcode_init() was not inited to zeroes, so it contained stack
debris.

Consequently, passing the cruft stored in this array to function
ipmi_hardcode_init_one() caused a crash when it was unable to detect
that the char * being passed was nonsense and tried to access the
address specified by the bogus pointer.

The fix is simply to initialize the si_type array to zeroes, so if
there were no type argument given to at the command line, function
ipmi_hardcode_init_one() could properly default to the kcs interface.

Signed-off-by: Tony Camuso 
Message-Id: <1554837603-40299-1-git-send-email-tcamuso@redhat.com>
Signed-off-by: Corey Minyard 
Signed-off-by: Sasha Levin

ipmi_si: Fix crash when using hard-coded device

2019-03-23T19:11:34+00:00

commit 41b766d661bf94a364960862cfc248a78313dbd3 upstream.

When excuting a command like:
  modprobe ipmi_si ports=0xffc0e3 type=bt
The system would get an oops.

The trouble here is that ipmi_si_hardcode_find_bmc() is called before
ipmi_si_platform_init(), but initialization of the hard-coded device
creates an IPMI platform device, which won't be initialized yet.

The real trouble is that hard-coded devices aren't created with
any device, and the fixup is done later.  So do it right, create the
hard-coded devices as normal platform devices.

This required adding some new resource types to the IPMI platform
code for passing information required by the hard-coded device
and adding some code to remove the hard-coded platform devices
on module removal.

To enforce the "hard-coded devices passed by the user take priority
over firmware devices" rule, some special code was added to check
and see if a hard-coded device already exists.

Reported-by: Yang Yingliang 
Cc: stable@vger.kernel.org # v4.15+
Signed-off-by: Corey Minyard 
Tested-by: Yang Yingliang 
Signed-off-by: Greg Kroah-Hartman

ipmi: Use more common logging styles

2018-09-18T21:15:33+00:00

Add and use #define pr_fmt/dev_fmt, and remove #define PFX

This also prefixes some messages that were not previously prefixed.

Miscellanea:

o Convert printk(KERN_ to pr_(
o Use %s, __func__ where appropriate

Signed-off-by: Joe Perches 
Signed-off-by: Corey Minyard

ipmi: Add or fix SPDX-License-Identifier in all files

2018-02-27T13:42:51+00:00

And get rid of the license text that is no longer necessary.

Signed-off-by: Corey Minyard 
Cc: Kees Cook 
Cc: Alistair Popple 
Cc: Jeremy Kerr 
Cc: Joel Stanley 
Cc: Rocky Craig

ipmi_si: Move hardcode handling to a separate file.

2017-09-27T21:03:45+00:00

Signed-off-by: Corey Minyard