linux-stable.git/drivers/cdrom/cdrom.c, branch linux-2.6.28.y

Commands needing to be retried require a complete re-initialization.

2008-12-12T15:04:26+00:00

The test-unit-ready portion of this patch was causing boots to fail on
my test machine (as in http://lkml.org/lkml/2008/12/5/161). With this
patch in place, the system is booting reliably.

Mike Anderson found the same problem in the hp_hw_start_stop code,
and I applied the same solution in cdrom_read_cdda_bpc.

Signed-off-by: Alan D. Brunelle 
Cc: Mike Anderson 
Signed-off-by: Jens Axboe

[PATCH] switch cdrom_{open,release,ioctl} to sane APIs

2008-10-21T11:47:22+00:00

... convert to it in callers

Signed-off-by: Al Viro

[PATCH] switch scsi_cmd_ioctl() to passing fmode_t

2008-10-21T11:47:14+00:00

Signed-off-by: Al Viro

[PATCH] eliminate use of ->f_flags in block methods

2008-10-21T11:47:08+00:00

store needed information in f_mode

Signed-off-by: Al Viro

block: introduce struct rq_map_data to use reserved pages

2008-10-09T06:56:10+00:00

This patch introduces struct rq_map_data to enable bio_copy_use_iov()
use reserved pages.

Currently, bio_copy_user_iov allocates bounce pages but
drivers/scsi/sg.c wants to allocate pages by itself and use
them. struct rq_map_data can be used to pass allocated pages to
bio_copy_user_iov.

The current users of bio_copy_user_iov simply passes NULL (they don't
want to use pre-allocated pages).

Signed-off-by: FUJITA Tomonori 
Cc: Jens Axboe 
Cc: Douglas Gilbert 
Cc: Mike Christie 
Cc: James Bottomley 
Signed-off-by: Jens Axboe

block: add gfp_mask argument to blk_rq_map_user and blk_rq_map_user_iov

2008-10-09T06:56:10+00:00

Currently, blk_rq_map_user and blk_rq_map_user_iov always do
GFP_KERNEL allocation.

This adds gfp_mask argument to blk_rq_map_user and blk_rq_map_user_iov
so sg can use it (sg always does GFP_ATOMIC allocation).

Signed-off-by: FUJITA Tomonori 
Signed-off-by: Douglas Gilbert 
Cc: Mike Christie 
Cc: James Bottomley 
Signed-off-by: Jens Axboe

cdrom: handle TOC

2008-08-18T19:40:04+00:00

This patch should fix TOC handling for cdroms that can not play audio.  It
extends commit af744e3294d09d706c4eae26cffaaa68a8d40337 ("cdrom: don't
check CDC_PLAY_AUDIO in cdrom_count_tracks()") with a safety check and
non-audio ioctls support.

Since CDC_PLAY_AUDIO flag was used not only to check ability to play audio
but also to ensure that audio_ioctl was not NULL, all TOC-related
operations had to use it.

As far as I understand, now audio_ioctl is never NULL, so a sanity check
during device registration should be sufficient.

It was tested on Optiarc AD7203A device, that has no ability to play
audio.

Cc: Tejun Heo 
Cc: Jens Axboe 
Cc: Borislav Petkov 
Signed-off-by: Andrew Morton 
[bart: remove now unneeded ->audio_ioctl check (noticed by Borislav)]
Signed-off-by: Bartlomiej Zolnierkiewicz

cdrom: don't check CDC_PLAY_AUDIO in cdrom_count_tracks()

2008-08-05T16:17:02+00:00

According to MMC-3 (or any later versions) READ TOCs are mandatory
commands and have nothing to do with CDC_PLAY_AUDIO.  I have no idea why
the check was put there in the first place but it now only breaks
automatic actions on certain drives.

Note that this test was only effective when ide-cdrom was being used
as sr didn't mask CDC_PLAY_AUDIO according to the capabilities.

Signed-off-by: Tejun Heo 
Acked-by: Jens Axboe 
Cc: Borislav Petkov 
Signed-off-by: Andrew Morton 
Signed-off-by: Bartlomiej Zolnierkiewicz

cdrom: revert commit 22a9189 (cdrom: use kmalloced buffers instead of buffers on stack)

2008-07-04T07:52:14+00:00

The commit 22a9189fd073db3d03a4cf8b8c098aa207602de1 (cdrom: use
kmalloced buffers instead of buffers on stack) is introduced to use
kmalloced buffers for packet commands to avoid stack corruption on non
coherent platforms.

SCSI cdrom uses blk_rq_map_kern, which properly avoids DMA on the
stack by using the bounce buffers. IDE cdrom also has the mechnism to
avoids DMA on the stack. So we don't need this extra complexitiy in
cdrom.c, such as allocating just 8 bytes. The lower layers can handle
it.

Signed-off-by: FUJITA Tomonori 
Cc: Thomas Bogendoerfer 
Cc: Bartlomiej Zolnierkiewicz 
Cc: Thomas Bogendoerfer 
Cc: Tejun Heo 
Cc: James Bottomley 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

block: no need to initialize rq->cmd with blk_get_request

2008-04-29T12:48:55+00:00

blk_get_request initializes rq->cmd (rq_init does) so the users don't
need to do that.

The purpose of this patch is to remove sizeof(rq->cmd) and &rq->cmd,
as a preparation for large command support, which changes rq->cmd from
the static array to a pointer. sizeof(rq->cmd) will not make sense and
&rq->cmd won't work.

Signed-off-by: FUJITA Tomonori 
Cc: James Bottomley 
Cc: Alasdair G Kergon 
Cc: Jens Axboe 
Signed-off-by: Jens Axboe