linux-stable.git/drivers/bluetooth/btintel.c, branch linux-5.10.y

Bluetooth: btintel: Fixe build regression

2024-04-13T10:59:56+00:00

commit 6e62ebfb49eb65bdcbfc5797db55e0ce7f79c3dd upstream.

This fixes the following build regression:

drivers-bluetooth-btintel.c-btintel_read_version()-warn:
passing-zero-to-PTR_ERR

Fixes: b79e04091010 ("Bluetooth: btintel: Fix null ptr deref in btintel_read_version")
Signed-off-by: Luiz Augusto von Dentz 
Signed-off-by: Greg Kroah-Hartman

Bluetooth: btintel: Fix null ptr deref in btintel_read_version

2024-04-13T10:59:44+00:00

[ Upstream commit b79e040910101b020931ba0c9a6b77e81ab7f645 ]

If hci_cmd_sync_complete() is triggered and skb is NULL, then
hdev->req_skb is NULL, which will cause this issue.

Reported-and-tested-by: syzbot+830d9e3fa61968246abd@syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis 
Signed-off-by: Luiz Augusto von Dentz 
Signed-off-by: Sasha Levin

Bluetooth: btintel: Functions to send firmware header / payload

2020-09-14T18:30:36+00:00

New generation controllers supports ECDSA secure boot engine.
This patch adds,

1) function to send ECDSA header

2) function to download complete firmware for new generation Intel
   controllers

Signed-off-by: Kiran K 
Signed-off-by: Amit K Bag 
Signed-off-by: Raghuram Hegde 
Reviewed-by: Chethan T N 
Reviewed-by: Srivatsa Ravishankar 
Signed-off-by: Marcel Holtmann

Bluetooth: btintel: Add infrastructure to read controller information

2020-09-14T18:30:36+00:00

New generation Intel controllers returns version information in TLV
format. This patch adds,

1) Enums, structures for TLV

2) function to read controller information, parse TLV data and populate
   intel_version_tlv structure

3) function to print version information

Signed-off-by: Kiran K 
Signed-off-by: Amit K Bag 
Signed-off-by: Raghuram Hegde 
Reviewed-by: Chethan T N 
Reviewed-by: Srivatsa Ravishankar 
Signed-off-by: Marcel Holtmann

Bluetooth: btintel: Refactor firmware download function

2020-09-13T07:58:22+00:00

Split firmware download code into two functions - one to download
header and other to download payload. This patch enhances readability
and reusabiltiy of code

Signed-off-by: Kiran K 
Reviewed-by: Chethan T N 
Reviewed-by: Sathish Narasimman 
Reviewed-by: Srivatsa Ravishankar 
Signed-off-by: Marcel Holtmann

Bluetooth: btusb: Configure Intel debug feature based on available support

2020-06-10T08:07:36+00:00

This patch shall enable the Intel telemetry exception format
based on the supported features

Signed-off-by: Chethan T N 
Signed-off-by: Ps AyappadasX 
Signed-off-by: Kiran K 
Signed-off-by: Marcel Holtmann

Bluetooth: btusb: Add support to read Intel debug feature

2020-06-10T04:51:49+00:00

The command shall read the Intel controller supported
debug feature. Based on the supported features additional debug
configuration shall be enabled.

Signed-off-by: Chethan T N 
Signed-off-by: Ps AyappadasX 
Signed-off-by: Kiran K 
Signed-off-by: Marcel Holtmann

Bluetooth: btintel: Replace zero-length array with flexible-array member

2020-02-13T07:28:38+00:00

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Marcel Holtmann

Bluetooth: btusb: Trigger Intel FW download error recovery

2019-10-17T07:23:47+00:00

Sometimes during FW data download stage, in case of an error is
encountered the controller device could not be recovered. To recover
from such failures send Intel hard Reset to re-trigger FW download in
following error scenarios:

1. Intel Read version command error
2. Firmware download timeout
3. Failure in Intel Soft Reset for switching to operational FW
4. Boot timeout for switching to operaional FW

Signed-off-by: Raghuram Hegde 
Signed-off-by: Chethan T N 
Signed-off-by: Amit K Bag 
Signed-off-by: Marcel Holtmann

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156

2019-05-30T18:26:35+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license as published by
  the free software foundation either version 2 of the license or at
  your option any later version this program is distributed in the
  hope that it will be useful but without any warranty without even
  the implied warranty of merchantability or fitness for a particular
  purpose see the gnu general public license for more details you
  should have received a copy of the gnu general public license along
  with this program if not write to the free software foundation inc
  59 temple place suite 330 boston ma 02111 1307 usa

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-or-later

has been chosen to replace the boilerplate/reference in 1334 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Reviewed-by: Richard Fontana 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190527070033.113240726@linutronix.de
Signed-off-by: Greg Kroah-Hartman