linux-stable.git/drivers/block, branch v3.18.48

paride: fix the "verbose" module param

2017-02-08T08:43:03+00:00

commit 946e87981942552e526aca9cb6204f02a6c847cb upstream.

The verbose module parameter can be set to 2 for extremely verbose
messages so the type should be int instead of bool.

Signed-off-by: Dan Carpenter 
Cc: Tim Waugh 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

nbd: ratelimit error msgs after socket close

2016-07-12T12:48:00+00:00

[ Upstream commit da6ccaaa79caca4f38b540b651238f87215217a2 ]

Make the "Attempted send on closed socket" error messages generated in
nbd_request_handler() ratelimited.

When the nbd socket is shutdown, the nbd_request_handler() function emits
an error message for every request remaining in its queue.  If the queue
is large, this will spam a large amount of messages to the log.  There's
no need for a separate error message for each request, so this patch
ratelimits it.

In the specific case this was found, the system was virtual and the error
messages were logged to the serial port, which overwhelmed it.

Fixes: 4d48a542b427 ("nbd: fix I/O hang on disconnected nbds")
Signed-off-by: Dan Streetman 
Signed-off-by: Markus Pargmann 
Signed-off-by: Sasha Levin

paride: make 'verbose' parameter an 'int' again

2016-07-12T12:47:52+00:00

[ Upstream commit dec63a4dec2d6d01346fd5d96062e67c0636852b ]

gcc-6.0 found an ancient bug in the paride driver, which had a
"module_param(verbose, bool, 0);" since before 2.6.12, but actually uses
it to accept '0', '1' or '2' as arguments:

  drivers/block/paride/pd.c: In function 'pd_init_dev_parms':
  drivers/block/paride/pd.c:298:29: warning: comparison of constant '1' with boolean expression is always false [-Wbool-compare]
   #define DBMSG(msg) ((verbose>1)?(msg):NULL)

In 2012, Rusty did a cleanup patch that also changed the type of the
variable to 'bool', which introduced what is now a gcc warning.

This changes the type back to 'int' and adapts the module_param() line
instead, so it should work as documented in case anyone ever cares about
running the ancient driver with debugging.

Fixes: 90ab5ee94171 ("module_param: make bool parameters really bool (drivers & misc)")
Signed-off-by: Arnd Bergmann 
Rusty Russell 
Cc: Tim Waugh 
Cc: Sudip Mukherjee 
Cc: Jens Axboe 
Cc: Greg Kroah-Hartman 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 

Signed-off-by: Sasha Levin

mtip32xx: Fix broken service thread handling

2016-07-12T12:47:23+00:00

[ Upstream commit cfc05bd31384c4898bf2437a4de5557f3cf9803a ]

Service thread does not detect the need for taskfile error hanlding. Fixed the
flag condition to process taskfile error.

Signed-off-by: Selvan Mani 
Signed-off-by: Asai Thambi S P 
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

mtip32xx: Fix for rmmod crash when drive is in FTL rebuild

2016-07-12T12:47:22+00:00

[ Upstream commit 59cf70e236c96594d9f1e065755d8fce9df5356b ]

When FTL rebuild is in progress, alloc_disk() initializes the disk
but device node will be created by add_disk() only after successful
completion of FTL rebuild. So, skip deletion of device node in
removal path when FTL rebuild is in progress.

Signed-off-by: Selvan Mani 
Signed-off-by: Asai Thambi S P 
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

rbd: use GFP_NOIO consistently for request allocations

2016-04-20T13:40:51+00:00

[ Upstream commit 2224d879c7c0f85c14183ef82eb48bd875ceb599 ]

As of 5a60e87603c4c533492c515b7f62578189b03c9c, RBD object request
allocations are made via rbd_obj_request_create() with GFP_NOIO.
However, subsequent OSD request allocations in rbd_osd_req_create*()
use GFP_ATOMIC.

With heavy page cache usage (e.g. OSDs running on same host as krbd
client), rbd_osd_req_create() order-1 GFP_ATOMIC allocations have been
observed to fail, where direct reclaim would have allowed GFP_NOIO
allocations to succeed.

Cc: stable@vger.kernel.org # 3.18+
Suggested-by: Vlastimil Babka 
Suggested-by: Neil Brown 
Signed-off-by: David Disseldorp 
Signed-off-by: Ilya Dryomov 
Signed-off-by: Sasha Levin

mtip32xx: Handle FTL rebuild failure state during device initialization

2016-04-18T12:49:23+00:00

[ Upstream commit aae4a033868c496adae86fc6f9c3e0c405bbf360 ]

Allow device initialization to finish gracefully when it is in
FTL rebuild failure state. Also, recover device out of this state
after successfully secure erasing it.

Signed-off-by: Selvan Mani 
Signed-off-by: Vignesh Gunasekaran 
Signed-off-by: Asai Thambi S P 
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

mtip32xx: fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT

2016-04-18T12:49:23+00:00

[ Upstream commit ee04bed690cb49a49512a641405bac42d13c2b2a ]

Fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT

Signed-off-by: Selvan Mani 
Signed-off-by: Asai Thambi S P 
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

mtip32xx: Handle safe removal during IO

2016-04-18T12:49:23+00:00

[ Upstream commit 51c6570eb922146470c2fe660c34585414679bd6 ]

Flush inflight IOs using fsync_bdev() when the device is safely
removed. Also, block further IOs in device open function.

Signed-off-by: Selvan Mani 
Signed-off-by: Rajesh Kumar Sambandam 
Signed-off-by: Asai Thambi S P 
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

mtip32xx: fix crash on surprise removal of the drive

2016-04-18T12:49:22+00:00

[ Upstream commit 2132a544727eb17f76bfef8b550a016a41c38821 ]

pci and block layers have changed a lot compared to when SRSI support was added.
Given the current state of pci and block layers, this driver do not have to do
any specific handling.

Signed-off-by: Asai Thambi S P 
Signed-off-by: Selvan Mani 
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin