linux-stable.git/drivers/block/zram, branch linux-6.2.y

block: count 'ios' and 'sectors' when io is done for bio-based device

2023-03-22T12:37:50+00:00

[ Upstream commit 5f27571382ca42daa3e3d40d1b252bf18c2b61d2 ]

While using iostat for raid, I observed very strange 'await'
occasionally, and turns out it's due to that 'ios' and 'sectors' is
counted in bdev_start_io_acct(), while 'nsecs' is counted in
bdev_end_io_acct(). I'm not sure why they are ccounted like that
but I think this behaviour is obviously wrong because user will get
wrong disk stats.

Fix the problem by counting 'ios' and 'sectors' when io is done, like
what rq-based device does.

Fixes: 394ffa503bc4 ("blk: introduce generic io stat accounting help function")
Signed-off-by: Yu Kuai 
Reviewed-by: Christoph Hellwig 
Link: https://lore.kernel.org/r/20230223091226.1135678-1-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

zram: remove unused stats fields

2022-11-30T23:59:01+00:00

We don't show num_reads and num_writes since we removed corresponding
sysfs nodes in 2017.  Block layer stats are exposed via
/sys/block/zramX/stat file.

However, we still increment those atomic vars and store them in zram
stats.  Remove leftovers.

Link: https://lkml.kernel.org/r/20221117141326.1105181-1-senozhatsky@chromium.org
Signed-off-by: Sergey Senozhatsky 
Acked-by: Minchan Kim 
Cc: Nitin Gupta 
Signed-off-by: Andrew Morton

zram: add incompressible flag to read_block_state()

2022-11-30T23:58:53+00:00

Add a new flag to zram block state that shows if the page is
incompressible: that none of the algorithm (including secondary ones)
could compress it.

Link: https://lkml.kernel.org/r/20221109115047.2921851-14-senozhatsky@chromium.org
Suggested-by: Minchan Kim 
Signed-off-by: Sergey Senozhatsky 
Acked-by: Minchan Kim 
Cc: Alexey Romanov 
Cc: Nhat Pham 
Cc: Nitin Gupta 
Cc: Suleiman Souhlal 
Signed-off-by: Andrew Morton

zram: add incompressible writeback

2022-11-30T23:58:53+00:00

Add support for incompressible pages writeback:

  echo incompressible > /sys/block/zramX/writeback

Link: https://lkml.kernel.org/r/20221109115047.2921851-13-senozhatsky@chromium.org
Signed-off-by: Sergey Senozhatsky 
Acked-by: Minchan Kim 
Cc: Alexey Romanov 
Cc: Nhat Pham 
Cc: Nitin Gupta 
Cc: Suleiman Souhlal 
Signed-off-by: Andrew Morton

zram: add algo parameter support to zram_recompress()

2022-11-30T23:58:52+00:00

Recompression iterates through all the registered secondary compression
algorithms in order of their priorities so that we have higher chances of
finding the algorithm that compresses a particular page.  This, however,
may not always be best approach and sometimes we may want to limit
recompression to only one particular algorithm.  For instance, when a
higher priority algorithm uses too much power and device has a relatively
low battery level we may want to limit recompression to use only a lower
priority algorithm, which uses less power.

Introduce algo= parameter support to recompression sysfs knob so that
user-sapce can request recompression with particular algorithm only:

  echo "type=idle algo=zstd" > /sys/block/zramX/recompress

Link: https://lkml.kernel.org/r/20221109115047.2921851-11-senozhatsky@chromium.org
Signed-off-by: Sergey Senozhatsky 
Acked-by: Minchan Kim 
Cc: Alexey Romanov 
Cc: Nhat Pham 
Cc: Nitin Gupta 
Cc: Suleiman Souhlal 
Signed-off-by: Andrew Morton

zram: remove redundant checks from zram_recompress()

2022-11-30T23:58:52+00:00

Size class index comparison is powerful enough so we can remove object
size comparisons.

Link: https://lkml.kernel.org/r/20221109115047.2921851-10-senozhatsky@chromium.org
Signed-off-by: Sergey Senozhatsky 
Acked-by: Minchan Kim 
Cc: Alexey Romanov 
Cc: Nhat Pham 
Cc: Nitin Gupta 
Cc: Suleiman Souhlal 
Signed-off-by: Andrew Morton

zram: add size class equals check into recompression

2022-11-30T23:58:52+00:00

It makes no sense for us to recompress the object if it will be in the
same size class.  We anyway don't get any memory gain.  But, at the same
time, we get a CPU time overhead when inserting this object into zspage
and decompressing it afterwards.

[senozhatsky: rebased and fixed conflicts]
Link: https://lkml.kernel.org/r/20221109115047.2921851-9-senozhatsky@chromium.org
Signed-off-by: Alexey Romanov 
Signed-off-by: Sergey Senozhatsky 
Acked-by: Minchan Kim 
Cc: Nhat Pham 
Cc: Nitin Gupta 
Cc: Suleiman Souhlal 
Signed-off-by: Andrew Morton

zram: use IS_ERR_VALUE() to check for zs_malloc() errors

2022-11-30T23:58:52+00:00

Avoid typecasts that are needed for IS_ERR() and use IS_ERR_VALUE()
instead.

Link: https://lkml.kernel.org/r/20221109115047.2921851-8-senozhatsky@chromium.org
Suggested-by: Andrew Morton 
Signed-off-by: Sergey Senozhatsky 
Acked-by: Minchan Kim 
Cc: Alexey Romanov 
Cc: Nhat Pham 
Cc: Nitin Gupta 
Cc: Suleiman Souhlal 
Signed-off-by: Andrew Morton

zram: clarify writeback_store() comment

2022-11-30T23:58:52+00:00

Re-phrase writeback BIO error comment.

Link: https://lkml.kernel.org/r/20221109115047.2921851-7-senozhatsky@chromium.org
Reported-by: Andrew Morton 
Signed-off-by: Sergey Senozhatsky 
Acked-by: Minchan Kim 
Cc: Alexey Romanov 
Cc: Nhat Pham 
Cc: Nitin Gupta 
Cc: Suleiman Souhlal 
Signed-off-by: Andrew Morton

zram: add recompress flag to read_block_state()

2022-11-30T23:58:51+00:00

Add a new flag to zram block state that shows if the page was recompressed
(using alternative compression algorithm).

Link: https://lkml.kernel.org/r/20221109115047.2921851-6-senozhatsky@chromium.org
Signed-off-by: Sergey Senozhatsky 
Acked-by: Minchan Kim 
Cc: Alexey Romanov 
Cc: Nhat Pham 
Cc: Nitin Gupta 
Cc: Suleiman Souhlal 
Signed-off-by: Andrew Morton