linux-stable.git/drivers/block/swim3.c, branch linux-3.18.y

block/swim3: Fix -EBUSY error when re-opening device after unmount

2019-02-20T09:09:03+00:00

[ Upstream commit 296dcc40f2f2e402facf7cd26cf3f2c8f4b17d47 ]

When the block device is opened with FMODE_EXCL, ref_count is set to -1.
This value doesn't get reset when the device is closed which means the
device cannot be opened again. Fix this by checking for refcount <= 0
in the release method.

Reported-and-tested-by: Stan Johnson 
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Finn Thain 
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

block: remove struct request buffer member

2014-04-15T20:03:02+00:00

This was used in the olden days, back when onions were proper
yellow. Basically it mapped to the current buffer to be
transferred. With highmem being added more than a decade ago,
most drivers map pages out of a bio, and rq->buffer isn't
pointing at anything valid.

Convert old style drivers to just use bio_data().

For the discard payload use case, just reference the page
in the bio.

Signed-off-by: Jens Axboe

swim3: fix interruptible_sleep_on race

2014-03-13T20:56:38+00:00

interruptible_sleep_on is racy and going away. This replaces the one
caller in the swim3 driver with the equivalent race-free
wait_event_interruptible call. Since we're here already, this
also fixes the case where we get interrupted from atomic context,
which used to just spin in the loop.

Signed-off-by: Arnd Bergmann 
Cc: Jens Axboe 
Signed-off-by: Jens Axboe

block_device_operations->release() should return void

2013-05-07T06:16:21+00:00

The value passed is 0 in all but "it can never happen" cases (and those
only in a couple of drivers) *and* it would've been lost on the way
out anyway, even if something tried to pass something meaningful.
Just don't bother.

Signed-off-by: Al Viro

drivers/block/swim3.c: fix null pointer dereference

2013-02-22T09:42:46+00:00

The use of pointer fs should be after the null check.

Signed-off-by: Cong Ding 
Cc: Jens Axboe 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

Drivers: block: remove __dev* attributes.

2013-01-03T23:57:15+00:00

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton 
Cc: Mike Miller 
Cc: Chirag Kantharia 
Cc: Geoff Levand 
Cc: Jim Paris 
Cc: Rusty Russell 
Cc: "Michael S. Tsirkin" 
Cc: Grant Likely 
Cc: Matthew Wilcox 
Cc: Keith Busch 
Cc: "David S. Miller" 
Cc: Benjamin Herrenschmidt 
Cc: NeilBrown 
Cc: Jens Axboe 
Cc: Tao Guo 
Signed-off-by: Greg Kroah-Hartman

block/swim3: Locking fixes

2011-12-12T11:42:12+00:00

The old PowerMac swim3 driver has some "interesting" locking issues,
using a private lock and failing to lock the queue before completing
requests, which triggered WARN_ONs among others.

This rips out the private lock, makes everything operate under the
block queue lock, and generally makes things simpler.

We used to also share a queue between the two possible instances which
was problematic since we might pick the wrong controller in some cases,
so make the queue and the current request per-instance and use
queuedata to point to our private data which is a lot cleaner.

We still share the queue lock but then, it's nearly impossible to actually
use 2 swim3's simultaneously: one would need to have a Wallstreet
PowerBook, the only machine afaik with two of these on the motherboard,
and populate both hotswap bays with a floppy drive (the machine ships
only with one), so nobody cares...

While at it, add a little fix to clear up stale interrupts when loading
the driver or plugging a floppy drive in a bay.

Signed-off-by: Benjamin Herrenschmidt 
Signed-off-by: Jens Axboe

block: swim3: fix unterminated of_device_id table

2011-08-03T13:02:55+00:00

of_device_id structures need a NULL terminating entry, add it.

Signed-off-by: Axel Lin 
Signed-off-by: Jens Axboe

block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers

2011-04-21T19:33:05+00:00

In-kernel disk event polling doesn't matter for legacy/fringe drivers
and may lead to infinite event loop if ->check_events() implementation
generates events on level condition instead of edge.

Now that block layer supports suppressing exporting unlisted events,
simply leaving disk->events cleared allows these drivers to keep the
internal revalidation behavior intact while avoiding weird
interactions with userland event handler.

Signed-off-by: Tejun Heo 
Cc: Kay Sievers 
Signed-off-by: Jens Axboe

swim[3]: Convert to bdops->check_events()

2011-03-09T18:54:28+00:00

Convert from ->media_changed() to ->check_events().

Both swim and swim3 buffer media changed state and clear it on
revalidation.  They will behave correctly with kernel event polling.

Signed-off-by: Tejun Heo 
Cc: Jens Axboe 
Cc: Kay Sievers 
Cc: Laurent Vivier 
Cc: Benjamin Herrenschmidt