linux-stable.git/drivers/block/rnbd, branch v5.10.7

block/rnbd-clt: Fix possible memleak

2020-12-30T10:53:57+00:00

[ Upstream commit 46067844efdb8275ade705923120fc5391543b53 ]

In error case, we do not free the memory for blk_symlink_name.

Do it by free the memory in error case, and set to NULL
afterwards.

Also fix the condition in rnbd_clt_remove_dev_symlink.

Fixes: 64e8a6ece1a5 ("block/rnbd-clt: Dynamically alloc buffer for pathname & blk_symlink_name")
Signed-off-by: Jack Wang 
Reviewed-by: Md Haris Iqbal 
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

block/rnbd-clt: Get rid of warning regarding size argument in strlcpy

2020-12-30T10:53:57+00:00

[ Upstream commit e7508d48565060af5d89f10cb83c9359c8ae1310 ]

The kernel test robot triggerred the following warning,

>> drivers/block/rnbd/rnbd-clt.c:1397:42: warning: size argument in
'strlcpy' call appears to be size of the source; expected the size of the
destination [-Wstrlcpy-strlcat-size]
	strlcpy(dev->pathname, pathname, strlen(pathname) + 1);
					      ~~~~~~~^~~~~~~~~~~~~

To get rid of the above warning, use a kstrdup as Bart suggested.

Fixes: 64e8a6ece1a5 ("block/rnbd-clt: Dynamically alloc buffer for pathname & blk_symlink_name")
Reported-by: kernel test robot 
Signed-off-by: Md Haris Iqbal 
Signed-off-by: Jack Wang 
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

block/rnbd: fix a null pointer dereference on dev->blk_symlink_name

2020-12-30T10:53:40+00:00

[ Upstream commit 733c15bd3a944b8eeaacdddf061759b6a83dd3f4 ]

Currently in the case where dev->blk_symlink_name fails to be allocates
the error return path attempts to set an end-of-string character to
the unallocated dev->blk_symlink_name causing a null pointer dereference
error. Fix this by returning with an explicity ENOMEM error (which also
is missing in the original code as was not initialized).

Fixes: 1eb54f8f5dd8 ("block/rnbd: client: sysfs interface functions")
Signed-off-by: Colin Ian King 
Addresses-Coverity: ("Dereference after null check")
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

block/rnbd-clt: Dynamically alloc buffer for pathname & blk_symlink_name

2020-12-30T10:53:40+00:00

[ Upstream commit 64e8a6ece1a5b1fa21316918053d068baeac84af ]

For every rnbd_clt_dev, we alloc the pathname and blk_symlink_name
statically to NAME_MAX which is 255 bytes. In most of the cases we only
need less than 10 bytes, so 500 bytes per block device are wasted.

This commit dynamically allocates memory buffer for pathname and
blk_symlink_name.

Signed-off-by: Md Haris Iqbal 
Signed-off-by: Jack Wang 
Reviewed-by: Lutz Pogrell 
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

block/rnbd-clt: send_msg_close if any error occurs after send_msg_open

2020-10-13T21:05:05+00:00

After send_msg_open is done, send_msg_close should be done
if any error occurs and it is necessary to recover
what has been done.

Signed-off-by: Gioh Kim 
Signed-off-by: Jack Wang 
Signed-off-by: Jens Axboe

block/rnbd-clt: do not cap max_hw_sectors & max_segments with remote device

2020-10-13T21:05:05+00:00

The max_hw_secotrs is only limited by the transport, not remote device,
block layer on server side will split to the device limit if it's too
big.

The max_segments, similar, and rtrs server will submit single buffer, so
no need to cap.

Signed-off-by: Jack Wang 
Signed-off-by: Jens Axboe

block/rnbd-clt: remove nr argument from send_usr_msg

2020-10-13T21:05:05+00:00

The argument is not needed since all callers pass 1 for it.

Signed-off-by: Guoqing Jiang 
Signed-off-by: Jack Wang 
Signed-off-by: Jens Axboe

blk-mq: Rename BLK_MQ_F_TAG_SHARED as BLK_MQ_F_TAG_QUEUE_SHARED

2020-09-03T21:20:46+00:00

BLK_MQ_F_TAG_SHARED actually means that tags is shared among request
queues, all of which should belong to LUNs attached to same HBA.

So rename it to make the point explicitly.

[jpg: rebase a few times, add rnbd-clt.c change]

Suggested-by: Bart Van Assche 
Signed-off-by: Ming Lei 
Signed-off-by: John Garry 
Tested-by: Douglas Gilbert 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Jens Axboe

block: add a new revalidate_disk_size helper

2020-09-02T14:00:07+00:00

revalidate_disk is a relative awkward helper for driver use, as it first
calls an optional driver method and then updates the block device size,
while most callers either don't need the method call at all, or want to
keep state between the caller and the called method.

Add a revalidate_disk_size helper that just performs the update of the
block device size from the gendisk one, and switch all drivers that do
not implement ->revalidate_disk to use the new helper instead of
revalidate_disk()

Signed-off-by: Christoph Hellwig 
Reviewed-by: Josef Bacik 
Reviewed-by: Johannes Thumshirn 
Acked-by: Song Liu 
Signed-off-by: Jens Axboe

block/rnbd: Ensure err is always initialized in process_rdma

2020-08-21T23:09:11+00:00

Clang warns:

drivers/block/rnbd/rnbd-srv.c:150:6: warning: variable 'err' is used
uninitialized whenever 'if' condition is true
[-Wsometimes-uninitialized]
        if (IS_ERR(bio)) {
            ^~~~~~~~~~~
drivers/block/rnbd/rnbd-srv.c:177:9: note: uninitialized use occurs here
        return err;
               ^~~
drivers/block/rnbd/rnbd-srv.c:150:2: note: remove the 'if' if its
condition is always false
        if (IS_ERR(bio)) {
        ^~~~~~~~~~~~~~~~~~
drivers/block/rnbd/rnbd-srv.c:126:9: note: initialize the variable 'err'
to silence this warning
        int err;
               ^
                = 0
1 warning generated.

err is indeed uninitialized when this statement is taken. Ensure that it
is assigned the error value of bio before jumping to the error handling
label.

Fixes: 735d77d4fd28 ("rnbd: remove rnbd_dev_submit_io")
Reported-by: Brooke Basile 
Signed-off-by: Nathan Chancellor 
Acked-by: Jack Wang 
Link: https://github.com/ClangBuiltLinux/linux/issues/1134
Signed-off-by: Jens Axboe