linux-stable.git/drivers/block/paride/pcd.c, branch v5.16.2

pcd: fix error codes in pcd_init_unit()

2021-10-18T20:41:59+00:00

Return -ENODEV on these error paths instead of returning success.

Fixes: af761f277b7f ("pcd: cleanup initialization")
Signed-off-by: Dan Carpenter 
Link: https://lore.kernel.org/r/20211001122623.GA2283@kili
Signed-off-by: Jens Axboe

pcd: capture errors on cdrom_register()

2021-10-18T20:41:36+00:00

No errors were being captured wehen cdrom_register() fails,
capture the error and return the error.

Signed-off-by: Luis Chamberlain 
Signed-off-by: Jens Axboe

pcd: fix ordering of unregister_cdrom()

2021-10-18T20:41:36+00:00

We first register cdrom and then we add_disk() and
so we we should likewise unregister the cdrom first and
then del_gendisk().

Signed-off-by: Luis Chamberlain 
Signed-off-by: Jens Axboe

pcd: add error handling support for add_disk()

2021-10-18T20:41:36+00:00

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

Signed-off-by: Luis Chamberlain 
Signed-off-by: Jens Axboe

pcd: cleanup initialization

2021-10-18T20:41:36+00:00

Refactor the pcd initialization to have a dedicated helper to initialize
a single disk.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

pcd: move the identify buffer into pcd_identify

2021-10-18T20:41:36+00:00

No need to pass it through a bunch of functions.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

pcd: use blk_mq_alloc_disk

2021-06-11T17:53:02+00:00

Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue
allocation.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Chaitanya Kulkarni 
Link: https://lore.kernel.org/r/20210602065345.355274-6-hch@lst.de
Signed-off-by: Jens Axboe

paride/pcd: use bdev_check_media_change

2020-09-10T15:32:31+00:00

The pcd driver does not have a ->revalidate_disk method, so it can just
use bdev_check_media_change without any additional changes.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Jens Axboe

block: add a cdrom_device_info pointer to struct gendisk

2020-05-04T16:13:42+00:00

Add a pointer to the CDROM information structure to struct gendisk.
This will allow various removable media file systems to call directly
into the CDROM layer instead of abusing ioctls with kernel pointers.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Damien Le Moal 
Signed-off-by: Jens Axboe

scsi: compat_ioctl: cdrom: Replace .ioctl with .compat_ioctl in four appropriate places

2020-02-24T20:06:07+00:00

Arnd Bergmann inadvertently typoed these in d320a9551e394 and 64cbfa96551a;
they seem to be the cause of
https://bugzilla.redhat.com/show_bug.cgi?id=1801353 , invalid SCSI commands
when udev tries to query a DVD drive.

[arnd] Found another instance of the same bug, also introduced in my
compat_ioctl series.

Link: https://bugzilla.redhat.com/show_bug.cgi?id=1801353
Link: https://lore.kernel.org/r/20200219165139.3467320-1-arnd@arndb.de
Fixes: c103d6ee69f9 ("compat_ioctl: ide: floppy: add handler")
Fixes: 64cbfa96551a ("compat_ioctl: move cdrom commands into cdrom.c")
Fixes: d320a9551e39 ("compat_ioctl: scsi: move ioctl handling into drivers")
Bisected-by: Chris Murphy 
Signed-off-by: Arnd Bergmann 
Signed-off-by: Adam Williamson 
Signed-off-by: Martin K. Petersen