linux-stable.git/drivers/block/null_blk_main.c, branch v5.4

null_blk: format pr_* logs with pr_fmt

2019-09-16T14:38:29+00:00

Instead of writing "null_blk: " at the beginning of each
pr_err/info/warn log message, format messages using pr_fmt() macro.

Reviewed-by: Chaitanya Kulkarni 
Signed-off-by: André Almeida 
Signed-off-by: Jens Axboe

null_blk: match the type of parameter nr_devices

2019-09-16T14:38:27+00:00

Since the variable nr_devices is an unsigned int, the module_param()
should also use this type. Change the type so they can match.

Fixes: f7c4ce890dd2 ("null_blk: validate the number of devices")
Reviewed-by: Chaitanya Kulkarni 
Signed-off-by: André Almeida 
Signed-off-by: Jens Axboe

null_blk: do not fail the module load with zero devices

2019-09-16T14:38:26+00:00

The module load should fail only if there is something wrong with the
configuration or if an error prevents it to work properly. The module
should be able to be loaded with (nr_device == 0), since it will not
trigger errors or be in malfunction state. Preventing loading with zero
devices also breaks applications that configures this module using
configfs API. Remove the nr_device check to fix this.

Fixes: f7c4ce890dd2 ("null_blk: validate the number of devices")
Reviewed-by: Chaitanya Kulkarni 
Signed-off-by: André Almeida 
Signed-off-by: Jens Axboe

null_blk: validate the number of devices

2019-09-11T22:04:25+00:00

A negative number of devices is nonsensical, so change the type to
unsigned. If the number of devices is 0, it is impossible for userspace
to interact with the module, so refuse loading the driver for that case.

Signed-off-by: André Almeida 
Signed-off-by: Jens Axboe

null_blk: fix module name at log message

2019-09-11T22:04:24+00:00

The name of the module is "null_blk", not "null". Make `pr_info()` follow
the pattern of `pr_err()` log messages.

Signed-off-by: André Almeida 
Signed-off-by: Jens Axboe

block: Set ELEVATOR_F_ZBD_SEQ_WRITE for nullblk zoned disks

2019-09-06T01:52:34+00:00

Using the helper blk_queue_required_elevator_features(), set the
elevator feature ELEVATOR_F_ZBD_SEQ_WRITE as required for the request
queue of null_blk devices created with zoned mode enabled.

This feature requirement can always be satisfied as the mq-deadline
elevator is always selected for in-kernel compilation when
CONFIG_BLK_DEV_ZONED (zoned block device support) is enabled.

Reviewed-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Ming Lei 
Signed-off-by: Damien Le Moal 
Signed-off-by: Jens Axboe

null_blk: create a helper for req completion

2019-08-23T12:58:05+00:00

This patch creates a helper function for handling the request
completion in the null_handle_cmd().

Reviewed-by: Christoph Hellwig 
Signed-off-by: Chaitanya Kulkarni 
Signed-off-by: Jens Axboe

null_blk: create a helper for zoned devices

2019-08-23T12:58:05+00:00

This patch creates a helper function for handling zoned block device
operations.

This patch also restructured the code for null_blk_zoned.c and uses the
pattern to return blk_status_t and catch the error in the function
null_handle_cmd() into cmd->error variable instead of setting it up in
the deeper layer just like the way it is done for flush, badblocks and
memory backed case in the null_handle_cmd(). We also move
null_handle_zoned() to the null_blk_zoned.c to keep the zoned code
separate.

Signed-off-by: Chaitanya Kulkarni 
Signed-off-by: Jens Axboe

null_blk: create a helper for mem-backed ops

2019-08-23T12:58:05+00:00

This patch creates a helper for handling requests when null_blk is
memory backed in the null_handle_cmd(). Although the helper is very
simple right now, it makes the code flow consistent with the rest of
code in the null_handle_cmd() and provides a uniform code structure
for future code.

Reviewed-by: Christoph Hellwig 
Signed-off-by: Chaitanya Kulkarni 
Signed-off-by: Jens Axboe

null_blk: create a helper for badblocks

2019-08-23T12:58:05+00:00

This patch creates a helper for handling badblocks code in the
null_handle_cmd().

Reviewed-by: Christoph Hellwig 
Signed-off-by: Chaitanya Kulkarni 
Signed-off-by: Jens Axboe