linux-stable.git/drivers/block/nbd.c, branch linux-3.19.y

nbd: fix possible memory leak

2015-04-19T08:10:16+00:00

commit ff6b8090e26ef7649ef0cc6b42389141ef48b0cf upstream.

we have already allocated memory for nbd_dev, but we were not
releasing that memory and just returning the error value.

Signed-off-by: Sudip Mukherjee 
Acked-by: Paul Clements 
Signed-off-by: Markus Pargmann 
Signed-off-by: Greg Kroah-Hartman

block: disable entropy contributions for nonrot devices

2014-10-04T16:55:32+00:00

Clear QUEUE_FLAG_ADD_RANDOM in all block drivers that set
QUEUE_FLAG_NONROT.

Historically, all block devices have automatically made entropy
contributions.  But as previously stated in commit e2e1a148 ("block: add
sysfs knob for turning off disk entropy contributions"):
    - On SSD disks, the completion times aren't as random as they
      are for rotational drives. So it's questionable whether they
      should contribute to the random pool in the first place.
    - Calling add_disk_randomness() has a lot of overhead.

There are more reliable sources for randomness than non-rotational block
devices.  From a security perspective it is better to err on the side of
caution than to allow entropy contributions from unreliable "random"
sources.

Signed-off-by: Mike Snitzer 
Signed-off-by: Jens Axboe

nbd: zero from and len fields in NBD_CMD_DISCONNECT.

2014-06-06T23:08:18+00:00

Len field is already set to zero, but not the from field which is sent
as 0xfffffffffffffe00.  This makes no sense, and may cause confuse
server implementations doing sanity checks (qemu-nbd is an example.)

Signed-off-by: Hani Benhabiles 
Cc: Paul Clements 
Cc: Paul Clements 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Merge branch 'sched/urgent' into sched/core, to avoid conflicts

2014-05-07T11:15:46+00:00

Signed-off-by: Ingo Molnar

sched, treewide: Replace hardcoded nice values with MIN_NICE/MAX_NICE

2014-04-18T10:07:24+00:00

Replace various -20/+19 hardcoded nice values with MIN_NICE/MAX_NICE.

Signed-off-by: Dongsheng Yang 
Acked-by: Tejun Heo 
Signed-off-by: Peter Zijlstra 
Link: http://lkml.kernel.org/r/ff13819fd09b7a5dba5ab5ae797f2e7019bdfa17.1394532288.git.yangds.fnst@cn.fujitsu.com
Cc: devel@driverdev.osuosl.org
Cc: devicetree@vger.kernel.org
Cc: fcoe-devel@open-fcoe.org
Cc: linux390@de.ibm.com
Cc: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Cc: linux-s390@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Cc: nbd-general@lists.sourceforge.net
Cc: ocfs2-devel@oss.oracle.com
Cc: openipmi-developer@lists.sourceforge.net
Cc: qla2xxx-upstream@qlogic.com
Cc: linux-arch@vger.kernel.org
[ Consolidated the patches, twiddled the changelog. ]
Signed-off-by: Ingo Molnar

switch nbd to sockfd_lookup/sockfd_put

2014-04-02T03:19:10+00:00

Signed-off-by: Al Viro

block: Immutable bio vecs

2013-11-24T06:33:49+00:00

This adds a mechanism by which we can advance a bio by an arbitrary
number of bytes without modifying the biovec: bio->bi_iter.bi_bvec_done
indicates the number of bytes completed in the current bvec.

Various driver code still needs to be updated to not refer to the bvec
directly before we can use this for interesting things, like efficient
bio splitting.

Signed-off-by: Kent Overstreet 
Cc: Jens Axboe 
Cc: Lars Ellenberg 
Cc: Paul Clements 
Cc: drbd-user@lists.linbit.com
Cc: nbd-general@lists.sourceforge.net

block: Convert bio_for_each_segment() to bvec_iter

2013-11-24T06:33:49+00:00

More prep work for immutable biovecs - with immutable bvecs drivers
won't be able to use the biovec directly, they'll need to use helpers
that take into account bio->bi_iter.bi_bvec_done.

This updates callers for the new usage without changing the
implementation yet.

Signed-off-by: Kent Overstreet 
Cc: Jens Axboe 
Cc: Geert Uytterhoeven 
Cc: Benjamin Herrenschmidt 
Cc: Paul Mackerras 
Cc: "Ed L. Cashin" 
Cc: Nick Piggin 
Cc: Lars Ellenberg 
Cc: Jiri Kosina 
Cc: Paul Clements 
Cc: Jim Paris 
Cc: Geoff Levand 
Cc: Yehuda Sadeh 
Cc: Sage Weil 
Cc: Alex Elder 
Cc: ceph-devel@vger.kernel.org
Cc: Joshua Morris 
Cc: Philip Kelleher 
Cc: Konrad Rzeszutek Wilk 
Cc: Jeremy Fitzhardinge 
Cc: Neil Brown 
Cc: Martin Schwidefsky 
Cc: Heiko Carstens 
Cc: linux390@de.ibm.com
Cc: Nagalakshmi Nandigama 
Cc: Sreekanth Reddy 
Cc: support@lsi.com
Cc: "James E.J. Bottomley" 
Cc: Greg Kroah-Hartman 
Cc: Alexander Viro 
Cc: Steven Whitehouse 
Cc: Herton Ronaldo Krzesinski 
Cc: Tejun Heo 
Cc: Andrew Morton 
Cc: Guo Chao 
Cc: Asai Thambi S P 
Cc: Selvan Mani 
Cc: Sam Bradshaw 
Cc: Matthew Wilcox 
Cc: Keith Busch 
Cc: Stephen Hemminger 
Cc: Quoc-Son Anh 
Cc: Sebastian Ott 
Cc: Nitin Gupta 
Cc: Minchan Kim 
Cc: Jerome Marchand 
Cc: Seth Jennings 
Cc: "Martin K. Petersen" 
Cc: Mike Snitzer 
Cc: Vivek Goyal 
Cc: "Darrick J. Wong" 
Cc: Chris Metcalf 
Cc: Jan Kara 
Cc: linux-m68k@lists.linux-m68k.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: drbd-user@lists.linbit.com
Cc: nbd-general@lists.sourceforge.net
Cc: cbe-oss-dev@lists.ozlabs.org
Cc: xen-devel@lists.xensource.com
Cc: virtualization@lists.linux-foundation.org
Cc: linux-raid@vger.kernel.org
Cc: linux-s390@vger.kernel.org
Cc: DL-MPTFusionLinux@lsi.com
Cc: linux-scsi@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Cc: linux-fsdevel@vger.kernel.org
Cc: cluster-devel@redhat.com
Cc: linux-mm@kvack.org
Acked-by: Geoff Levand

nbd: correct disconnect behavior

2013-07-03T23:08:05+00:00

Currently, when a disconnect is requested by the user (via NBD_DISCONNECT
ioctl) the return from NBD_DO_IT is undefined (it is usually one of
several error codes).  This means that nbd-client does not know if a
manual disconnect was performed or whether a network error occurred.
Because of this, nbd-client's persist mode (which tries to reconnect after
error, but not after manual disconnect) does not always work correctly.

This change fixes this by causing NBD_DO_IT to always return 0 if a user
requests a disconnect.  This means that nbd-client can correctly either
persist the connection (if an error occurred) or disconnect (if the user
requested it).

Signed-off-by: Paul Clements 
Acked-by: Rob Landley 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

nbd: remove bogus BUG_ON in NBD_CLEAR_QUE

2013-07-03T23:08:05+00:00

The NBD_CLEAR_QUE ioctl has been deprecated for quite some time (its job
is now done by two other ioctls).  We should stop trying to make bogus
assertions in it.  Also, user-level code should remove calls to
NBD_CLEAR_QUE, ASAP.

Signed-off-by: Michal Belczyk 
Signed-off-by: Paul Clements 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds