linux-stable.git/drivers/block/floppy.c, branch linux-2.6.36.y

floppy: make controller const

2010-08-07T16:52:31+00:00

The struct cont_t is just a set of virtual function pointers.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

block: push down BKL into .open and .release

2010-08-07T16:25:34+00:00

The open and release block_device_operations are currently
called with the BKL held. In order to change that, we must
first make sure that all drivers that currently rely
on this have no regressions.

This blindly pushes the BKL into all .open and .release
operations for all block drivers to prepare for the
next step. The drivers can subsequently replace the BKL
with their own locks or remove it completely when it can
be shown that it is not needed.

The functions blkdev_get and blkdev_put are the only
remaining users of the big kernel lock in the block
layer, besides a few uses in the ioctl code, none
of which need to serialize with blkdev_{get,put}.

Most of these two functions is also under the protection
of bdev->bd_mutex, including the actual calls to
->open and ->release, and the common code does not
access any global data structures that need the BKL.

Signed-off-by: Arnd Bergmann 
Acked-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: push down BKL into .locked_ioctl

2010-08-07T16:25:00+00:00

As a preparation for the removal of the big kernel
lock in the block layer, this removes the BKL
from the common ioctl handling code, moving it
into every single driver still using it.

Signed-off-by: Arnd Bergmann 
Acked-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

floppy: use warning macros

2010-08-07T16:15:43+00:00

Convert assertions to use WARN().  There are several error checks in the
code for things that should never happen.  Convert them to standard
warnings so kerneloops.org will see them.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

floppy: use wait_event_interruptible

2010-08-07T16:15:41+00:00

Convert wait loops to use wait_event_ macros.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

floppy: fix signed/unsigned warnings

2010-08-07T16:15:39+00:00

Ioctl cmd value is unsigned, so change normalize_ioctl

Signed-off-by: Stephen Hemminger 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

floppy: cmos attribute should be static

2010-08-07T16:15:37+00:00

As reported by sparse, cmos attribute is local.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

floppy: use atomic type for usage_count

2010-08-07T16:15:36+00:00

The usage_count was being protected by a lock which was only there to
create an atomic counter.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

floppy: silence warning during disk test

2010-08-07T16:15:34+00:00

The first thing the floppy does is read block 0 to test geometry and to
test for disk presence.  If disk is not present this causes a console
warning message about failed I/O.  Set flag to silence.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

floppy: remove unnecessary inlines

2010-08-07T16:15:32+00:00

These routines are all big enough that is better to let the compiler
decide to inline or not.

Signed-off-by: Stephen Hemminger 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe