linux-stable.git/drivers/block/drbd/drbd_req.c, branch linux-5.11.y

drbd: remove ->this_bdev

2020-10-05T16:38:33+00:00

DRBD keeps a block device open just to get and set the capacity from
it.  Switch to primarily using the disk capacity as intended by the
block layer, and sync it to the bdev using revalidate_disk_size.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

treewide: Use fallthrough pseudo-keyword

2020-08-23T22:36:59+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva

block: rename generic_make_request to submit_bio_noacct

2020-07-01T13:27:24+00:00

generic_make_request has always been very confusingly misnamed, so rename
it to submit_bio_noacct to make it clear that it is submit_bio minus
accounting and a few checks.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: move ->make_request_fn to struct block_device_operations

2020-07-01T13:27:24+00:00

The make_request_fn is a little weird in that it sits directly in
struct request_queue instead of an operation vector.  Replace it with
a block_device_operations method called submit_bio (which describes much
better what it does).  Also remove the request_queue argument to it, as
the queue can be derived pretty trivially from the bio.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: remove the request_queue argument from blk_queue_split

2020-07-01T13:27:23+00:00

The queue can be trivially derived from the bio, so pass one less
argument.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

drbd: stop using ->queuedata

2020-07-01T13:27:23+00:00

Instead of setting up the queuedata as well just use one private data
field.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

drbd: use bio_{start,end}_io_acct

2020-05-27T11:21:23+00:00

Switch drbd to use the nicer bio accounting helpers.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Konstantin Khlebnikov 
Signed-off-by: Jens Axboe

drbd: Remove unneeded semicolon

2019-11-28T17:40:44+00:00

Fixes coccicheck warning:

drivers/block/drbd/drbd_req.c:887:2-3: Unneeded semicolon

Reported-by: Hulk Robot 
Signed-off-by: zhengbin 
Signed-off-by: Jens Axboe

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 91

2019-05-24T15:37:53+00:00

Based on 1 normalized pattern(s):

  is free software you can redistribute it and or modify it under the
  terms of the gnu general public license as published by the free
  software foundation either version 2 or at your option any later
  version [drbd] is distributed in the hope that it will be useful but
  without any warranty without even the implied warranty of
  merchantability or fitness for a particular purpose see the gnu
  general public license for more details you should have received a
  copy of the gnu general public license along with [drbd] see the
  file copying if not write to the free software foundation 675 mass
  ave cambridge ma 02139 usa

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-or-later

has been chosen to replace the boilerplate/reference in 16 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Reviewed-by: Richard Fontana 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190520075212.050796421@linutronix.de
Signed-off-by: Greg Kroah-Hartman

block: Mark expected switch fall-throughs

2019-04-09T16:48:15+00:00

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

This patch fixes the following warnings:

drivers/block/drbd/drbd_int.h:1774:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/block/drbd/drbd_int.h:1774:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/block/drbd/drbd_int.h:1774:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/block/drbd/drbd_int.h:1774:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/block/drbd/drbd_int.h:1774:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/block/drbd/drbd_receiver.c:3093:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/block/drbd/drbd_receiver.c:3120:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/block/drbd/drbd_req.c:856:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough

Reviewed-by: Chaitanya Kulkarni 
Acked-by: Roland Kammerer 
Signed-off-by: Gustavo A. R. Silva