linux-stable.git/drivers/base/bus.c, branch linux-2.6.33.y

driver core: Prevent reference to freed memory on error path

2009-12-23T19:23:44+00:00

priv is drv->p. So only free drv->p after we've finished using priv.

Found using a static code analysis tool

Signed-off-by: Phil Carmody 
Signed-off-by: Greg Kroah-Hartman

Driver core: allow certain drivers prohibit bind/unbind via sysfs

2009-10-30T21:59:51+00:00

Platform drivers registered via platform_driver_probe() can be bound
to devices only once, upon registration, because discard their probe()
routines to save memory. Unbinding the driver through sysfs 'unbind'
leaves the device stranded and confuses users so let's not create
bind and unbind attributes for such drivers.

Signed-off-by: Dmitry Torokhov 
Cc: Éric Piel 
Signed-off-by: Greg Kroah-Hartman

Driver core: add new device to bus's list before probing

2009-09-15T16:50:46+00:00

This patch (as1271) affects when new devices get linked into their
bus's list of devices.  Currently this happens after probing, and it
doesn't happen at all if probing fails.  Clearly this is wrong,
because at that point quite a few symbolic links have already been
created in sysfs.  We are committed to adding the device, so it should
be linked into the bus's list regardless.

In addition, this needs to happen before the uevent announcing the new
device gets issued.  Otherwise user programs might try to access the
device before it has been added to the bus.

To fix both these problems, the patch moves the call to
klist_add_tail() forward from bus_attach_device() to bus_add_device().
Since bus_attach_device() now does nothing but probe for drivers, it
has been renamed to bus_probe_device().  And lastly, the kerneldoc is
updated.

Signed-off-by: Alan Stern 
CC: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

trivial: fix grammo in bus_for_each_dev() kerneldoc

2009-06-12T16:01:48+00:00

Signed-off-by: Alex Chiang 
Acked-by: Randy Dunlap 
Signed-off-by: Jiri Kosina

Driver Core: do not oops when driver_unregister() is called for unregistered drivers

2009-05-28T21:24:07+00:00

We also fix a problem with cleaning up properly when initializing
drivers and devices, so checks like this will work successfully.

Portions of the patch by Linus and Greg and Ingo.

Reported-by: Ozan Çağlayan 
Signed-off-by: Kay Sievers 
Cc: Linus Torvalds 
Cc: Ingo Molnar 
Signed-off-by: Greg Kroah-Hartman

driver core: move knode_bus into private structure

2009-03-24T23:38:25+00:00

Nothing outside of the driver core should ever touch knode_bus, so
move it out of the public eye.

Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

driver-core: do not register a driver with bus_type not registered

2009-03-24T23:38:25+00:00

If the bus_type is not registerd, driver_register to that bus will cause oops.

I found this bug when test built-in usb serial drivers (ie. aircable driver)
with 'nousb' cmdline params.

In this patch:
1. set the bus->p=NULL when bus_register failed and unregisterd.
2. if bus->p is NULL, driver_register BUG_ON will be triggered.

Signed-off-by: Dave Young 
Signed-off-by: Greg Kroah-Hartman

driver core: check bus->match without holding device lock

2009-03-24T23:38:24+00:00

This patch moves bus->match out from driver_probe_device and
does not hold device lock to check the match between a device
and a driver.

The idea has been verified by the commit 6cd495860901,
which leads to a faster boot. But the commit 6cd495860901 has
the following drawbacks: 1),only does the quick check in
the path of __driver_attach->driver_probe_device, not in other
paths; 2),for a matched device and driver, check the same match
twice. It is a waste of cpu ,especially for some drivers with long
device id table (eg. usb-storage driver).

This patch adds a helper of driver_match_device to check the match
in all paths, and testes the match only once.

Signed-off-by: Ming Lei 
Acked-by: Cornelia Huck 
Signed-off-by: Greg Kroah-Hartman

Revert "driver core: move knode_bus into private structure"

2009-01-09T22:32:46+00:00

This reverts commit b9daa99ee533578e3f88231e7a16784dcb44ec42.

Turns out that device_initialize shouldn't fail silently.
This series needs to be reworked in order to get into proper
shape.

Reported-by: Stefan Richter 
Cc: Alan Cox 
Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

driver core: move knode_bus into private structure

2009-01-06T18:44:33+00:00

Nothing outside of the driver core should ever touch knode_bus, so
move it out of the public eye.

Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman