linux-stable.git/drivers/auxdisplay, branch linux-5.17.y

auxdisplay: lcd2s: Use proper API to free the instance of charlcd object

2022-03-02T23:30:31+00:00

While it might work, the current approach is fragile in a few ways:
- whenever members in the structure are shuffled, the pointer will be wrong
- the resource freeing may include more than covered by kfree()

Fix this by using charlcd_free() call instead of kfree().

Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display")
Cc: Lars Poeschel 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Miguel Ojeda

auxdisplay: lcd2s: Fix memory leak in ->remove()

2022-03-02T23:30:14+00:00

Once allocated the struct lcd2s_data is never freed.
Fix the memory leak by switching to devm_kzalloc().

Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display")
Cc: Lars Poeschel 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Miguel Ojeda

auxdisplay: lcd2s: Fix lcd2s_redefine_char() feature

2022-03-02T23:29:26+00:00

It seems that the lcd2s_redefine_char() has never been properly
tested. The buffer is filled by DEF_CUSTOM_CHAR command followed
by the character number (from 0 to 7), but immediately after that
these bytes are rewritten by the decoded hex stream.

Fix the index to fill the buffer after the command and number.

Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display")
Cc: Lars Poeschel 
Signed-off-by: Andy Shevchenko 
Reviewed-by: Geert Uytterhoeven 
[fixed typo in commit message]
Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: checking for pointer reference before dereferencing

2021-11-24T10:46:52+00:00

Check if the pointer lcd->ops->init_display exists before dereferencing it.
If a driver called charlcd_init() without defining the ops, this would
return segmentation fault, as happened to me when implementing a charlcd
driver.  Checking the pointer before dereferencing protects from
segmentation fault.

Signed-off-by: Luiz Sampaio 
Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: fixing coding style issue

2021-11-24T10:46:42+00:00

Removing 'int' from 'unsigned long int' declaration, which is unnecessary.

Signed-off-by: Luiz Sampaio 
Signed-off-by: Miguel Ojeda

auxdisplay: cfag12864bfb: code indent should use tabs where possible

2021-10-21T22:13:16+00:00

Resolves the checkpatch error.

Signed-off-by: Huiquan Deng 
[reworded and avoid moving the line]
Signed-off-by: Miguel Ojeda

auxdisplay: ht16k33: remove superfluous header files

2021-10-21T22:07:29+00:00

ht16k33.c doesn't use any macro or function declared in
linux/slab.h. Thus, these files can be removed from ht16k33.c
safely without affecting the compilation.

Signed-off-by: Mianhan Liu 
Acked-by: Robin van der Gracht 
[reworded]
Signed-off-by: Miguel Ojeda

auxdisplay: ks0108: remove superfluous header files

2021-10-21T22:04:43+00:00

ks0108.c doesn't use any macro or function declared in
linux/fs.h, linux/io.h and linux/uaccess.h. Thus,
these files can be removed from ks0108.c safely without
affecting the compilation.

Signed-off-by: Mianhan Liu 
[reworded]
Signed-off-by: Miguel Ojeda

auxdisplay: cfag12864bfb: remove superfluous header files

2021-10-21T22:03:49+00:00

cfag12864bfb.c doesn't use any macro or function declared in
linux/delay.h, linux/string.h and linux/uaccess.h. Thus,
these files can be removed from cfag12864bfb.c safely without
affecting the compilation.

Signed-off-by: Mianhan Liu 
[reworded]
Signed-off-by: Miguel Ojeda

auxdisplay: ht16k33: Make use of device properties

2021-10-21T21:36:30+00:00

The device property API allows drivers to gather device resources from
different sources, such as ACPI, and lift the dependency on Device Tree.
Convert the driver to unleash the power of the device property API.

Suggested-by: Marek Behún 
Signed-off-by: Geert Uytterhoeven 
Reviewed-by: Andy Shevchenko 
Acked-by: Robin van der Gracht 
Signed-off-by: Miguel Ojeda