linux-stable.git/drivers/ata, branch linux-3.8.y

sata_highbank: Rename proc_name to the module name

2013-05-08T03:08:22+00:00

commit 2cc1144a31f76d4a9fb48bec5d6ba1359f980813 upstream.

mkinitrd looks at /sys/class/scsi_host/host$hostnum/proc_name to find
the module name of a disk driver. Current name is "highbank-ahci" but
the module is "sata_highbank". Rename it to match the module name.

Signed-off-by: Robert Richter 
Cc: Rob Herring 
Cc: Alexander Graf 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: acpi: make ata_ap_acpi_handle not block

2013-05-08T03:08:22+00:00

commit d66af4df0837f21bf267305dc5ccab2d29e24d86 upstream.

Since commit 30dcf76acc, ata_ap_acpi_handle will always do a namespace
walk, which requires acquiring an acpi namespace mutex. This made it
impossible to be used when calling path has held a spinlock.

For example, it can occur in the following code path for pata_acpi:
ata_scsi_queuecmd (ap->lock is acquired)
  __ata_scsi_queuecmd
    ata_scsi_translate
      ata_qc_issue
        pacpi_qc_issue
          ata_acpi_stm
            ata_ap_acpi_handle
              acpi_get_child
                acpi_walk_namespace
                  acpi_ut_acquire_mutex (acquire mutex while holding lock)
This caused scheduling while atomic bug, as reported in bug #56781.

Actually, ata_ap_acpi_handle doesn't have to walk the namespace every
time it is called, it can simply return the bound acpi handle on the
corresponding SCSI host. The reason previously it is not done this way
is, ata_ap_acpi_handle is used in the binding function
ata_acpi_bind_host by ata_acpi_gtm when the handle is not bound to the
SCSI host yet. Since we already have the ATA port's handle in its
binding function, we can simply use it instead of calling
ata_ap_acpi_handle there. So introduce a new function __ata_acpi_gtm,
where it will receive an acpi handle param in addition to the ATA port
which is solely used for debug statement. With this change, we can make
ata_ap_acpi_handle simply return the bound handle for SCSI host instead
of walking the acpi namespace now.

Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=56781
Reported-and-tested-by: 
Signed-off-by: Aaron Lu 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

ata_piix: Fix DVD not dectected at some Haswell platforms

2013-04-12T16:52:07+00:00

commit b55f84e2d527182e7c611d466cd0bb6ddce201de upstream.

There is a quirk patch 5e5a4f5d5a08c9c504fe956391ac3dae2c66556d
"ata_piix: make DVD Drive recognisable on systems with Intel Sandybridge
 chipsets(v2)" fixing the 4 ports IDE controller 32bit PIO mode.

We've hit a problem with DVD not recognized on Haswell Desktop platform which
includes Lynx Point 2-port SATA controller.

This quirk patch disables 32bit PIO on this controller in IDE mode.

v2: Change spelling error in statememnt pointed by Sergei Shtylyov.
v3: Change comment statememnt and spliting line over 80 characters pointed by
    Libor Pechacek and also rebase the patch against 3.8-rc7 kernel.

Tested-by: Lee, Chun-Yi 
Signed-off-by: Youquan Song 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: fix DMA to stack in reading devslp_timing parameters

2013-04-12T16:52:06+00:00

commit 8e725c7f8a60feaa88edacd4dee2c754d5ae7706 upstream.

Commit 803739d25c2343da6d2f95eebdcbc08bf67097d4 ("[libata] replace
sata_settings with devslp_timing"), which was also Cc: stable, used a
stack buffer to receive data from ata_read_log_page(), which triggers
the following warning:
 ahci 0000:00:1f.2: DMA-API: device driver maps memory fromstack [addr=ffff880140469948]

Fix this by using ap->sector_buf instead of a stack buffer.

Signed-off-by: David Woodhouse 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: Set max sector to 65535 for Slimtype DVD A DS8A8SH drive

2013-04-12T16:52:06+00:00

commit a32450e127fc6e5ca6d958ceb3cfea4d30a00846 upstream.

The Slimtype DVD A  DS8A8SH drive locks up when max sector is smaller than
65535, and the blow backtrace is observed on locking up:

INFO: task flush-8:32:1130 blocked for more than 120 seconds.
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
flush-8:32      D ffffffff8180cf60     0  1130      2 0x00000000
 ffff880273aef618 0000000000000046 0000000000000005 ffff880273aee000
 ffff880273aee000 ffff880273aeffd8 ffff880273aee010 ffff880273aee000
 ffff880273aeffd8 ffff880273aee000 ffff88026e842ea0 ffff880274a10000
Call Trace:
 [] schedule+0x5d/0x70
 [] io_schedule+0x8c/0xd0
 [] get_request+0x731/0x7d0
 [] ? cfq_allow_merge+0x50/0x90
 [] ? wake_up_bit+0x40/0x40
 [] ? bio_attempt_back_merge+0x33/0x110
 [] blk_queue_bio+0x23a/0x3f0
 [] generic_make_request+0xc6/0x120
 [] submit_bio+0x138/0x160
 [] ? bio_alloc_bioset+0x96/0x120
 [] submit_bh+0x1f1/0x220
 [] __block_write_full_page+0x228/0x340
 [] ? attach_nobh_buffers+0xc0/0xc0
 [] ? I_BDEV+0x10/0x10
 [] ? I_BDEV+0x10/0x10
 [] block_write_full_page_endio+0xe6/0x100
 [] block_write_full_page+0x15/0x20
 [] blkdev_writepage+0x18/0x20
 [] __writepage+0x17/0x40
 [] write_cache_pages+0x34a/0x4a0
 [] ? set_page_dirty+0x70/0x70
 [] generic_writepages+0x51/0x80
 [] do_writepages+0x20/0x50
 [] __writeback_single_inode+0xa6/0x2b0
 [] writeback_sb_inodes+0x311/0x4d0
 [] __writeback_inodes_wb+0x86/0xd0
 [] wb_writeback+0x1a3/0x330
 [] ? _raw_spin_lock_irqsave+0x3f/0x50
 [] ? get_nr_inodes+0x52/0x70
 [] wb_do_writeback+0x1dc/0x260
 [] ? schedule_timeout+0x204/0x240
 [] bdi_writeback_thread+0x102/0x2b0
 [] ? wb_do_writeback+0x260/0x260
 [] kthread+0xc0/0xd0
 [] ? kthread_worker_fn+0x1b0/0x1b0
 [] ret_from_fork+0x7c/0xb0
 [] ? kthread_worker_fn+0x1b0/0x1b0

 The above trace was triggered by
   "dd if=/dev/zero of=/dev/sr0 bs=2048 count=32768"

 It was previously working by accident, since another bug introduced
 by 4dce8ba94c7 (libata: Use 'bool' return value for ata_id_XXX) caused
 all drives to use maxsect=65535.

Signed-off-by: Shan Hai 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

ahci: Add Device IDs for Intel Wellsburg PCH

2013-03-03T22:03:39+00:00

commit 151743fd8dfb02956c5184b5f4f0f42677eb75bc upstream.

This patch adds the AHCI-mode SATA Device IDs for the Intel Wellsburg PCH

Signed-off-by: James Ralston 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

ahci: AHCI-mode SATA patch for Intel Avoton DeviceIDs

2013-03-03T22:03:39+00:00

commit 29e674dd5c8e781589f09c3ee139c80f6da274e4 upstream.

This patch adds the AHCI and RAID-mode SATA DeviceIDs for the Intel Avoton SOC.

Signed-off-by: Seth Heasley 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

ata_piix: Add Device IDs for Intel Wellsburg PCH

2013-03-03T22:03:39+00:00

commit 3aee8bc52c415aba8148f144e5e5359b0fd75dd1 upstream.

This patch adds the IDE-mode SATA Device IDs for the Intel Wellsburg PCH

Signed-off-by: James Ralston 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

ata_piix: IDE-mode SATA patch for Intel Avoton DeviceIDs

2013-03-03T22:03:39+00:00

commit aaa515277db9585eeb4fdeb4637b9f9df50a1dd9 upstream.

This patch adds the IDE-mode SATA DeviceIDs for the Intel Avoton SOC.

Signed-off-by: Seth Heasley 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

[libata] replace sata_settings with devslp_timing

2013-01-14T18:29:15+00:00

NCQ capability was used to check availability of SATA Settings page
from Identify Device Data Log, which contains DevSlp timing variables.
It does not work on some HDDs and leads to error messages.

IDENTIFY word 78 bit 5(Hardware Feature Control) can't work either
because it is only the sufficient condition of Identify Device data
log, not the necessary condition.

This patch replaced ata_device->sata_settings with ->devslp_timing
to only save DevSlp timing variables(8 bytes), instead of the whole
SATA Settings page(512 bytes).

Addresses https://bugzilla.kernel.org/show_bug.cgi?id=51881

Reported-by: Borislav Petkov 
Signed-off-by: Shane Huang 
Cc: stable@vger.kernel.org
Signed-off-by: Jeff Garzik