linux-stable.git/drivers/ata, branch linux-2.6.30.y

ahci: restore pci_intx() handling

2009-10-05T15:27:58+00:00

commit 31b239ad1ba7225435e13f5afc47e48eb674c0cc upstream.

Commit a5bfc4714b3f01365aef89a92673f2ceb1ccf246 dropped explicit
pci_intx() manipulation from ahci because it seemed unnecessary and
ahci doesn't seem to be the right place to be tweaking it if it were.
This was largely okay but there are exceptions.  There was one on an
embedded platform which was fixed via firmware and now bko#14124
reports it on a HP DL320.

  http://bugzilla.kernel.org/show_bug.cgi?id=14124

I still think this isn't something libata drivers should be caring
about (the only ones which are calling pci_intx() explicitly are
libata ones and one other driver) but for now reverting the change
seems to be the right thing to do.

Signed-off-by: Tejun Heo 
Reported-by: Thomas Jarosch 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: fix off-by-one error in ata_tf_read_block()

2009-09-24T15:27:28+00:00

commit ac8672ea922bde59acf50eaa1eaa1640a6395fd2 upstream.

ata_tf_read_block() has off-by-one error when converting CHS address
to LBA.  The bug isn't very visible because ata_tf_read_block() is
used only when generating sense data for a failed RW command and CHS
addressing isn't used too often these days.

This problem was spotted by Atsushi Nemoto.

Signed-off-by: Tejun Heo 
Reported-by: Atsushi Nemoto 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: OCZ Vertex can't do HPA

2009-09-09T03:33:40+00:00

commit 7831387bda72af3059be48d39846d3eb6d8ce2f6 upstream.

OCZ Vertex SSD can't do HPA and not in a usual way.  It reports HPA,
allows unlocking but then fails all IOs which fall in the unlocked
area.  Quirk it so that HPA unlocking is not used for the device.

Reported by Daniel Perup in bnc#522414.

 https://bugzilla.novell.com/show_bug.cgi?id=522414

Signed-off-by: Tejun Heo 
Reported-by: Daniel Perup 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: fix follow-up SRST failure path

2009-07-30T21:40:33+00:00

commit fe2c4d018fc6127610fef677e020b3bb41cfaaaf upstream.

ata_eh_reset() was missing error return handling after follow-up SRST
allowing EH to continue the normal probing path after reset failure.
This was discovered while testing new WD 2TB drives which take longer
than 10 secs to spin up and cause the first follow-up SRST to time
out.

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

pata_netcell: Fix typo

2009-06-08T16:12:28+00:00

The previous patch submission had a I typo I didn't catch but Bartlomiej
noted. Guess this proves the point about any patch being risky late in an rc

Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

[libata] pata_ali: Use IGN_SIMPLEX

2009-06-05T21:10:54+00:00

Some ALi devices report simplex if they have been disabled and re-enabled, and
restoring the byte does not work. Ignore it - the needed supporting logic is
already present for the SATA ULi ports.

Signed-off-by: Alan Cox 
Signed-off-by: Jeff Garzik

ata_piix: Add HP Compaq nc6000 to the broken poweroff list

2009-06-05T18:41:13+00:00

HP Compaq nc6000 suffers from the double disk spindown issue.
Add it to the broken poweroff DMI list.

Signed-off-by: Ville Syrjala 
Signed-off-by: Jeff Garzik

ahci: add warning messages for hp laptops with broken suspend

2009-06-05T18:41:10+00:00

Harddisks on HP dv[4-6] and HDX18 fail to come online after resume on
earlier BIOSen.  Fortunately, HP recently released BIOS updates for
all machines to fix the issue.  Detect old BIOSen, warn the user to
update BIOS on boot and suspend attempts and fail suspend.

Kudos to all the bug reporters.

Signed-off-by: Tejun Heo 
Cc: kernel.org@epperson.homelinux.net
Cc: emisca@gmail.com
Cc: Gadi Cohen 
Cc: Paul Swanson 
Cc: s@ourada.org
Cc: Trevor Davenport 
Cc: corruptor1972 
Cc: Victoria Wilson 
Cc: khiraly 
Cc: Sean 
Signed-off-by: Jeff Garzik

pata_efar: fix PIO2 underclocking

2009-06-05T18:40:52+00:00

Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
fast timing bank starting with PIO2, just like the PIIX/ICH drivers do.
Also, fix/rephrase some comments while at it.

Signed-off-by: Sergei Shtylyov 
Signed-off-by: Jeff Garzik

pata_legacy: wait for async probing

2009-06-05T18:40:46+00:00

The basic problem here that pata_legacy attaches the host, sees if it found
any devices and detaches it if none were found.  With async probing, it's not
waiting until discovery is finished before deciding it has no devices and
trying the detach leading to this warning:

ata1: PATA max PIO4 cmd 0x1f0 ctl 0x3f6 irq 14
------------[ cut here ]------------
WARNING: at drivers/ata/libata-core.c:6222 ata_host_detach+0x75/0x90()
Modules linked in:
Pid: 1, comm: swapper Not tainted 2.6.30-rc7 #1
Call Trace:
 [] ? ata_host_detach+0x75/0x90
 [] ? ata_host_detach+0x75/0x90
 [] ? warn_slowpath_common+0x45/0x80
 [] ? warn_slowpath_null+0xa/0x10
 [] ? ata_host_detach+0x75/0x90
 [] ? legacy_init+0x44e/0x87f
 [] ? legacy_init+0x0/0x87f
 [] ? _stext+0x21/0x140
 [] ? proc_register+0x2f/0x190
 [] ? create_proc_entry+0x5c/0xc0
 [] ? register_irq_proc+0x6e/0x90
 [] ? kernel_init+0x6e/0xbf
 [] ? kernel_init+0x0/0xbf
 [] ? kernel_thread_helper+0x7/0x10
---[ end trace ef1ee36e873ae3a0 ]---

Because it detaches before the probe is complete.

One way to fix it would be to put an async_synchronize_full() before looking
for devices, which this patch does.  A better way might be to separate libata
into its own domain and only wait for that.

Reported-by: Mikael Pettersson 
Signed-off-by: James Bottomley 
Signed-off-by: Jeff Garzik