linux-stable.git/drivers/ata, branch linux-2.6.27.y

libata: set queue DMA alignment to sector size for ATAPI too

2012-02-11T14:37:24+00:00

commit 729a6a300e628a48cf12bac93a964a535e83cd1d upstream.

ata_pio_sectors() expects buffer for each sector to be contained in a
single page; otherwise, it ends up overrunning the first page.  This
is achieved by setting queue DMA alignment.  If sector_size is smaller
than PAGE_SIZE and all buffers are sector_size aligned, buffer for
each sector is always contained in a single page.

This wasn't applied to ATAPI devices but IDENTIFY_PACKET is executed
as ATA_PROT_PIO and thus uses ata_pio_sectors().  Newer versions of
udev issue IDENTIFY_PACKET with unaligned buffer triggering the
problem and causing oops.

This patch fixes the problem by setting sdev->sector_size to
ATA_SECT_SIZE on ATATPI devices and always setting DMA alignment to
sector_size.  While at it, add a warning for the unlikely but still
possible scenario where sector_size is larger than PAGE_SIZE, in which
case the alignment wouldn't be enough.

Signed-off-by: Tejun Heo 
Reported-by: John Stanley 
Tested-by: John Stanley 
Signed-off-by: Jeff Garzik 
Signed-off-by: Jonathan Liu 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Willy Tarreau

sata_via: Delay on vt6420 when starting ATAPI DMA write

2012-02-11T14:37:24+00:00

commit a55ab496ea9c820b7192c15ef1fbf3291edfe638 upstream.

When writing a disc on certain lite-on dvd-writers (also rebadged
as optiarc/LG/...) connected to a vt6420, the ATAPI CDB ends
up in the datastream and on the disc, causing silent corruption.
Delaying between sending the CDB and starting DMA seems to
prevent this.

I do not know if there are burners that do not suffer from
this, but the patch should be safe for those as well.

There are many reports of this issue, but AFAICT no solution was
found before. For example:
http://lkml.indiana.edu/hypermail/linux/kernel/0802.3/0561.html

Signed-off-by: Bart Hartgers 
Signed-off-by: Jeff Garzik 
[bwh: Remove version bump for 2.6.32]
Signed-off-by: Greg Kroah-Hartman 

Signed-off-by: Willy Tarreau

ahci: AHCI mode SATA patch for Intel Patsburg SATA RAID controller

2011-04-30T14:53:16+00:00

commit 64a3903d0885879ba8706a8bcf71c5e3e7664db2 upstream.

This patch adds an updated SATA RAID DeviceID for the Intel Patsburg PCH.

Signed-off-by: Seth Heasley 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

ahci: AHCI mode SATA patch for Intel DH89xxCC DeviceIDs

2011-04-30T14:53:16+00:00

commit a4a461a6df6c0481d5a3d61660ed97f5b539cf16 upstream.

This patch adds the AHCI-mode SATA DeviceID for the Intel DH89xxCC PCH.

Signed-off-by: Seth Heasley 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

ahci: AHCI and RAID mode SATA patch for Intel Patsburg DeviceIDs

2011-04-30T14:53:15+00:00

commit 992b3fb9b5391bc4de5b42bb810dc6dd583a6c4a upstream.

This patch adds the Intel Patsburg (PCH) SATA AHCI and RAID Controller
DeviceIDs.

Signed-off-by: Seth Heasley 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

ahci: AHCI and RAID mode SATA patch for Intel Cougar Point DeviceIDs

2011-04-30T14:53:15+00:00

commit 5623cab83ea61e0420f2064216d83eab067a24c6 upstream.

Signed-off-by: Seth Heasley 
Signed-off-by: Jeff Garzik

ahci: add device IDs for Ibex Peak ahci controllers

2011-04-30T14:53:15+00:00

commit c1f57d9b9846e7366c328f916d1a82d03ba4312c upstream.

Add device IDS for Ibex Peak SATA AHCI Controllers

Signed-off-by: Jaroslav Kysela 
Signed-off-by: David Milburn 
Signed-off-by: Jeff Garzik

libata: no special completion processing for EH commands

2011-04-30T14:53:14+00:00

commit f08dc1ac6b15c681f4643d8da1700e06c3855608 upstream.

ata_qc_complete() contains special handling for certain commands.  For
example, it schedules EH for device revalidation after certain
configurations are changed.  These shouldn't be applied to EH
commands but they were.

In most cases, it doesn't cause an actual problem because EH doesn't
issue any command which would trigger special handling; however, ACPI
can issue such commands via _GTF which can cause weird interactions.

Restructure ata_qc_complete() such that EH commands are always passed
on to __ata_qc_complete().

stable: Please apply to -stable only after 2.6.38 is released.

Signed-off-by: Tejun Heo 
Reported-by: Kyle McMartin 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: fix NULL sdev dereference race in atapi_qc_complete()

2010-12-09T21:24:17+00:00

commit 2a5f07b5ec098edc69e05fdd2f35d3fbb1235723 upstream.

SCSI commands may be issued between __scsi_add_device() and dev->sdev
assignment, so it's unsafe for ata_qc_complete() to dereference
dev->sdev->locked without checking whether it's NULL or not.  Fix it.

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: disable ATAPI AN by default

2010-07-05T18:08:41+00:00

commit e7ecd435692ca9bde9d124be30b3a26e672ea6c2 upstream.

There are ATAPI devices which raise AN when hit by commands issued by
open().  This leads to infinite loop of AN -> MEDIA_CHANGE uevent ->
udev open() to check media -> AN.

Both ACS and SerialATA standards don't define in which case ATAPI
devices are supposed to raise or not raise AN.  They both list media
insertion event as a possible use case for ATAPI ANs but there is no
clear description of what constitutes such events.  As such, it seems
a bit too naive to export ANs directly to userland as MEDIA_CHANGE
events without further verification (which should behave similarly to
windows as it apparently is the only thing that some hardware vendors
are testing against).

This patch adds libata.atapi_an module parameter and disables ATAPI AN
by default for now.

Signed-off-by: Tejun Heo 
Cc: Kay Sievers 
Cc: Nick Bowler 
Cc: David Zeuthen 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman