linux-stable.git/drivers/ata, branch linux-2.6.25.y

ahci: retry enabling AHCI a few times before spitting out WARN_ON()

2008-08-01T18:50:50+00:00

commit 15fe982e429e0e6b7466719acb6cfd9dbfe47f0c upstream

ahci: retry enabling AHCI a few times before spitting out WARN_ON()

Some chips need AHCI_EN set more than once to actually set it.  Try a
few times before giving up and spitting out WARN_ON().

Signed-off-by: Tejun Heo 
Cc: Peer Chen 
Cc: Volker Armin Hemmann 
Signed-off-by: Jeff Garzik 
Cc: Chuck Ebbert 
Signed-off-by: Greg Kroah-Hartman

pata_atiixp: Don't disable

2008-08-01T18:50:44+00:00

Commit 05177f178efe1459d2d0ac05430027ba201889a4 upstream

pata_atiixp: Don't disable

A couple of distributions (Fedora, Ubuntu) were having weird problems with the
ATI IXP series PATA controllers being reported as simplex.  At the heart of
the problem is that both distros ignored the recommendations to load pata_acpi
and ata_generic *AFTER* specific host drivers.

The underlying cause however is that if you D3 and then D0 an ATI IXP it
helpfully throws away some configuration and won't let you rewrite it.

Add checks to ata_generic and pata_acpi to pin ATIIXP devices.  Possibly the
real answer here is to quirk them and pin them, but right now we can't do that
before they've been pcim_enable()'d by a driver.

I'm indebted to David Gero for this.  His bug report not only reported the
problem but identified the cause correctly and he had tested the right values
to prove what was going on

[If you backport this for 2.6.24 you will need to pull in the 2.6.25
removal of the bogus WARN_ON() in pcim_enagle]

Signed-off-by: Alan Cox 
Tested-by: David Gero 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik

libata: force hardreset if link is in powersave mode

2008-06-09T18:26:59+00:00

Inhibiting link PM mode doesn't bring the link back online if it's
already in powersave mode.  If SRST is used in these cases, libata EH
thinks that the link is offline and fails detection.  Force hardreset
if link is in powersave mode.

Signed-off-by: Tejun Heo 
Cc: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Chris Wright

ata_piix: verify SIDPR access before enabling it

2008-05-15T14:50:04+00:00

commit cb6716c879ecf49e2af344926c6a476821812061 upstream

On certain configurations (certain macbooks), even though all the
conditions for SIDPR access described in the datasheet are met,
actually reading those registers just returns 0 and have no effect on
write.  Verify SIDPR is actually working before enabling it.

This is reported by Ryan Roth in bz#10512.

Signed-off-by: Tejun Heo 
Cc: Ryan Roth 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

[libata] make ali_atapi_dma static

2008-04-12T04:16:49+00:00

This patch makes the needlessly global ali_atapi_dma static.

Signed-off-by: Adrian Bunk 
Signed-off-by: Jeff Garzik

[libata] sata_svw: fix reversed port count

2008-04-12T04:11:35+00:00

According to Broadcom, two chips have their port counts flipped.  The proper
count is:

0x241 is 8 ports
0x242 is 4 ports

Reported by Yohei Honda on kernel bz 10424.

Signed-off-by: Jeff Garzik

ata/sata_fsl: Remove unused variable in sata_fsl_probe

2008-04-09T05:06:37+00:00

In sata_fsl_probe memory is allocated but never used or deallocated.
Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=10404

Thanks to Daniel Marjamäki for the bug report.

Reported-by: Daniel Marjamäki 
Signed-off-by: Johann Felix Soden 
Signed-off-by: Jeff Garzik

pata_sil680: Fix build on arch/ppc

2008-04-09T05:06:33+00:00

Commit 0f436eff54f90419ac1b8accfb3e6e17c4b49a4e breaks build on
arch/ppc as it doesn't implement the machine_is() macro.

This fixes it by using CONFIG_PPC_MERGE instead which represents
arch/powerpc only, while CONFIG_PPC is set for both.

Signed-off-by: Benjamin Herrenschmidt 
Signed-off-by: Jeff Garzik

pata_ali: disable ATAPI DMA

2008-04-04T06:43:38+00:00

ATAPI DMA just doesn't work reliably on pata_ali.  The IDE driver can
do it but for some mysterious reason, pata_ali can't.  This patch
disables it by default and makes the driver whine during
initialization.  "pata_ali.atapi_dma" parameter is added so that user
can bypass the workaround.

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik

libata: ATA_12/16 doesn't fall into ATAPI_MISC

2008-04-04T06:43:36+00:00

SAT passthrus don't really fit into ATAPI_MISC class.  SAT passthru
commands always transfer multiple of 512 bytes and variable length
response is not allowed.  This patch creates a separate category -
ATAPI_PASS_THRU - for these.

This fixes HSM violation on "hdparm -I".

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik