linux-stable.git/drivers/ata/libahci_platform.c, branch linux-4.19.y

ata: libahci_platform: Sanity check the DT child nodes number

2022-10-26T11:19:40+00:00

[ Upstream commit 3c132ea6508b34956e5ed88d04936983ec230601 ]

Having greater than AHCI_MAX_PORTS (32) ports detected isn't that critical
from the further AHCI-platform initialization point of view since
exceeding the ports upper limit will cause allocating more resources than
will be used afterwards. But detecting too many child DT-nodes doesn't
seem right since it's very unlikely to have it on an ordinary platform. In
accordance with the AHCI specification there can't be more than 32 ports
implemented at least due to having the CAP.NP field of 5 bits wide and the
PI register of dword size. Thus if such situation is found the DTB must
have been corrupted and the data read from it shouldn't be reliable. Let's
consider that as an erroneous situation and halt further resources
allocation.

Note it's logically more correct to have the nports set only after the
initialization value is checked for being sane. So while at it let's make
sure nports is assigned with a correct value.

Signed-off-by: Serge Semin 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal 
Signed-off-by: Sasha Levin

ata: libahci_platform: fix IRQ check

2021-05-22T08:59:33+00:00

[ Upstream commit b30d0040f06159de97ad9c0b1536f47250719d7d ]

Iff platform_get_irq() returns 0, ahci_platform_init_host() would return 0
early (as if the call was successful). Override IRQ0 with -EINVAL instead
as the 'libata' regards 0 as "no IRQ" (thus polling) anyway...

Fixes: c034640a32f8 ("ata: libahci: properly propagate return value of platform_get_irq()")
Signed-off-by: Sergey Shtylyov 
Link: https://lore.kernel.org/r/4448c8cc-331f-2915-0e17-38ea34e251c8@omprussia.ru
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

ata: libahci_platform: Export again ahci_platform_able_phys()

2020-01-09T09:19:01+00:00

commit 84b032dbfdf1c139cd2b864e43959510646975f8 upstream.

This reverts commit 6bb86fefa086faba7b60bb452300b76a47cde1a5
("libahci_platform: Staticize ahci_platform_able_phys()") we are
going to need ahci_platform_{enable,disable}_phys() in a subsequent
commit for ahci_brcm.c in order to properly control the PHY
initialization order.

Also make sure the function prototypes are declared in
include/linux/ahci_platform.h as a result.

Cc: stable@vger.kernel.org
Reviewed-by: Hans de Goede 
Signed-off-by: Florian Fainelli 
Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

ata: libahci: do not complain in case of deferred probe

2019-08-25T08:47:55+00:00

[ Upstream commit 090bb803708198e5ab6b0046398c7ed9f4d12d6b ]

Retrieving PHYs can defer the probe, do not spawn an error when
-EPROBE_DEFER is returned, it is normal behavior.

Fixes: b1a9edbda040 ("ata: libahci: allow to use multiple PHYs")
Reviewed-by: Hans de Goede 
Signed-off-by: Miquel Raynal 
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

ata: libahci_platform: add reset control support

2018-08-22T15:08:27+00:00

Add support to get and control a list of resets for the device
as optional and shared. These resets must be kept de-asserted until
the device is enabled.

This is specified as shared because some SoCs like UniPhier series
have common reset controls with all ahci controller instances.

However, according to Thierry's view,
https://www.spinics.net/lists/linux-ide/msg55357.html
some hardware-specific drivers already use their own resets,
and the common reset make a path to occur double controls of resets.

The ahci_platform_get_resources() can get and control the reset
only when the second argument includes AHCI_PLATFORM_GET_RESETS bit.

Suggested-by: Hans de Goede 
Cc: Thierry Reding 
Signed-off-by: Kunihiko Hayashi 
Reviewed-by: Hans de Goede 
Signed-off-by: Tejun Heo

ata: add an extra argument to ahci_platform_get_resources()

2018-08-22T15:08:27+00:00

Add an extra argument to ahci_platform_get_resources(), that is
for the bitmap representing the resource to get in this function.

Currently there is no resources to be defined, so all the callers set
'0' to the argument.

Suggested-by: Hans de Goede 
Cc: Thierry Reding 
Cc: Matthias Brugger 
Cc: Patrice Chotard 
Cc: Maxime Ripard 
Signed-off-by: Kunihiko Hayashi 
Reviewed-by: Hans de Goede 
Signed-off-by: Tejun Heo

Revert "ata: ahci_platform: allow disabling of hotplug to save power"

2018-08-06T17:22:35+00:00

This reverts commit aece27a2f01be4bb7683790f69cd1bed3a0929a2.

Causes boot failure on some devices.

 http://lore.kernel.org/r/CA+G9fYuKW_jCFZPqG4tz=QY9ROfHO38KiCp9XTA+KaDOFVtcqQ@mail.gmail.com

Signed-off-by: Tejun Heo

Revert "ata: ahci_platform: convert kcalloc to devm_kcalloc"

2018-07-24T16:44:24+00:00

Since ahci_platform_put_resources() use target_pwrs after "devm_" freed
it, we cannot use devm_kcalloc for allocating target_pwrs.

This reverts commit bd0038b1b4f499d814d8f33a55b1df5ea6cf3b85.

Reported-and-reviwed-by: Mikko Perttunen 
Tested-by: Marcel Ziswiler 
Tested-by: Jon Hunter 
Signed-off-by: Corentin Labbe 
Signed-off-by: Tejun Heo

ata: ahci_platform: convert kcalloc to devm_kcalloc

2018-07-12T20:02:39+00:00

Like phys, target_pwrs could be allocated with devm_ function

Signed-off-by: Corentin Labbe 
Reviewed-by: Hans de Goede 
Signed-off-by: Tejun Heo

ata: ahci_platform: convert kzallloc to kcalloc

2018-07-12T20:02:39+00:00

It's better to kcalloc instead of kzalloc(n * sizeof())

Signed-off-by: Corentin Labbe 
Reviewed-by: Hans de Goede 
Signed-off-by: Tejun Heo