linux-stable.git/drivers/acpi/utils.c, branch v6.7

ACPI: utils: Fix error path in acpi_evaluate_reference()

2023-12-07T20:38:21+00:00

If a pointer to an uninitialized struct acpi_handle_list is passed to
acpi_evaluate_reference() and it decides to bail out early, either
because acpi_evaluate_object() fails, or because it produces invalid
data, the handles pointer from the struct acpi_handle_list will be
passed to kfree() and if it is not NULL, the kernel will crash on an
attempt to free unallocated memory.

Address this by moving the "end" label in acpi_evaluate_reference() to
the end of the function, which is sufficient, because no cleanup is
needed in that case.

Fixes: 2e57d10a6591 ("ACPI: utils: Dynamically determine acpi_handle_list size")
Signed-off-by: Rafael J. Wysocki 
Tested-by: Woody Suwalski

Merge branches 'acpi-ec', 'acpi-sysfs', 'acpi-misc' and 'acpi-uid'

2023-10-26T12:59:52+00:00

Merge ACPI EC driver updates, ACPI sysfs interface updates, misc updates
related to ACPI and changes related to ACPI _UID handling for 6.7-rc1:

 - Add EC GPE detection quirk for HP 250 G7 Notebook PC (Jonathan
   Denose).

 - Fix and clean up create_pnp_modalias() and create_of_modalias()
   (Christophe JAILLET).

 - Modify 2 pieces of code to use acpi_evaluate_dsm_typed() (Andy
   Shevchenko).

 - Define acpi_dev_uid_match() for matching _UID and use it in several
   places (Raag Jadav).

 - Use acpi_device_uid() for fetching _UID in 2 places (Raag Jadav).

* acpi-ec:
  ACPI: EC: Add quirk for HP 250 G7 Notebook PC

* acpi-sysfs:
  ACPI: sysfs: Clean up create_pnp_modalias() and create_of_modalias()
  ACPI: sysfs: Fix create_pnp_modalias() and create_of_modalias()

* acpi-misc:
  ACPI: x86: s2idle: Switch to use acpi_evaluate_dsm_typed()
  ACPI: PCI: Switch to use acpi_evaluate_dsm_typed()

* acpi-uid:
  perf: arm_cspmu: use acpi_dev_hid_uid_match() for matching _HID and _UID
  ACPI: x86: use acpi_dev_uid_match() for matching _UID
  ACPI: utils: use acpi_dev_uid_match() for matching _UID
  pinctrl: intel: use acpi_dev_uid_match() for matching _UID
  ACPI: utils: Introduce acpi_dev_uid_match() for matching _UID
  perf: qcom: use acpi_device_uid() for fetching _UID
  ACPI: sysfs: use acpi_device_uid() for fetching _UID

ACPI: utils: use acpi_dev_uid_match() for matching _UID

2023-10-24T19:49:27+00:00

Convert manual _UID references to use the standard ACPI helper.

Signed-off-by: Raag Jadav 
Signed-off-by: Rafael J. Wysocki

ACPI: utils: Introduce acpi_dev_uid_match() for matching _UID

2023-10-24T19:49:27+00:00

Introduce acpi_dev_uid_match() helper that matches the device with
supplied _UID string.

Signed-off-by: Raag Jadav 
Reviewed-by: Mika Westerberg 
Signed-off-by: Rafael J. Wysocki

ACPI: utils: Remove redundant braces around individual statement

2023-10-03T19:04:49+00:00

Remove braces that are not required for a one-line statement which
follows a control statement.

Signed-off-by: Jonathan Bergh 
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki

ACPI: utils: Fix up white space in a few places

2023-10-03T19:04:49+00:00

Fix up the following formatting issues flagged by checkpatch:
 * Remove indentation before goto label
 * Remove whitespace ahead of a comma in parameter list

Signed-off-by: Jonathan Bergh 
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki

ACPI: utils: Dynamically determine acpi_handle_list size

2023-09-29T10:40:35+00:00

Address a long-standing "TBD" comment in the ACPI headers regarding the
number of handles in struct acpi_handle_list.

The number 10, which along with the comment dates back to 2.4.23, seems
like it may have been arbitrarily chosen and isn't sufficient in all
cases [1].

Finally change the code to dynamically determine the size of the handles
table in struct acpi_handle_list and allocate it accordingly.

Update the users of to struct acpi_handle_list to take the additional
dynamic allocation into account.

Link: https://lore.kernel.org/linux-acpi/20230809094451.15473-1-ivan.hu@canonical.com # [1]
Co-developed-by: Vicki Pfau 
Signed-off-by: Vicki Pfau 
Signed-off-by: Rafael J. Wysocki

Merge branch 'acpi-uid'

2022-10-03T18:09:22+00:00

Merge ACPI _UID handling unification changes for 6.1-rc1:

 - Introduce acpi_dev_uid_to_integer() to convert a _UID string into an
   integer value (Andy Shevchenko).

 - Use acpi_dev_uid_to_integer() in several places to unify _UID
   handling (Andy Shevchenko).

* acpi-uid:
  efi/dev-path-parser: Refactor _UID handling to use acpi_dev_uid_to_integer()
  spi: pxa2xx: Refactor _UID handling to use acpi_dev_uid_to_integer()
  perf: qcom_l2_pmu: Refactor _UID handling to use acpi_dev_uid_to_integer()
  i2c: mlxbf: Refactor _UID handling to use acpi_dev_uid_to_integer()
  i2c: amd-mp2-plat: Refactor _UID handling to use acpi_dev_uid_to_integer()
  ACPI: x86: Refactor _UID handling to use acpi_dev_uid_to_integer()
  ACPI: LPSS: Refactor _UID handling to use acpi_dev_uid_to_integer()
  ACPI: utils: Add acpi_dev_uid_to_integer() helper to get _UID as integer

ACPI: utils: Add acpi_dev_uid_to_integer() helper to get _UID as integer

2022-09-19T16:34:42+00:00

Some users interpret _UID only as integer and for them it's easier to
have an integer representation of _UID. Add respective helper for that.

Signed-off-by: Andy Shevchenko 
Reviewed-by: Hans de Goede 
Signed-off-by: Rafael J. Wysocki

ACPI: move from strlcpy() with unused retval to strscpy()

2022-08-23T16:55:14+00:00

Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: Wolfram Sang 
Signed-off-by: Rafael J. Wysocki