linux-stable.git/drivers/acpi/tables.c, branch linux-4.2.y

ACPI / table: Print GIC information when MADT is parsed

2015-03-25T11:49:31+00:00

When MADT is parsed, print GIC information as debug message:

ACPI: GICC (acpi_id[0x0000] address[00000000e112f000] MPIDR[0x0] enabled)
ACPI: GICC (acpi_id[0x0001] address[00000000e112f000] MPIDR[0x1] enabled)
...
ACPI: GICC (acpi_id[0x0201] address[00000000e112f000] MPIDR[0x201] enabled)

This debug information will be very helpful to bring up early systems to
see if acpi_id and MPIDR are matched or not as spec defined.

CC: Rafael J. Wysocki 
Tested-by: Suravee Suthikulpanit 
Tested-by: Yijing Wang 
Tested-by: Mark Langsdorf 
Tested-by: Jon Masters 
Tested-by: Timur Tabi 
Tested-by: Robert Richter 
Acked-by: Robert Richter 
Acked-by: Sudeep Holla 
Acked-by: Rafael J. Wysocki 
Acked-by: Lorenzo Pieralisi 
Acked-by: Grant Likely 
Signed-off-by: Hanjun Guo 
Signed-off-by: Tomasz Nowicki 
Signed-off-by: Will Deacon

ACPI / table: Use pr_debug() instead of pr_info() for MADT table scanning

2015-03-25T11:49:30+00:00

For a normal 8 cpu sockets system, it will up to 240 cpu threads (Xeon E7
v2 family for now), and we need 240 entries for local apic or local x2apic
in MADT table, so it will be much verbose information printed with a slow
uart console when system booted, this will be even worse with large system
with 16/32 cpu sockets.

This patch just use pr_debug() instead of pr_info() for ioapic/iosapic,
local apic/x2apic/sapic structures when scanning the MADT table to remove
those verbose information, but leave other structures unchanged.

CC: Rafael J Wysocki 
Acked-by: Rafael J. Wysocki 
Acked-by: Olof Johansson 
Acked-by: Grant Likely 
Tested-by: Timur Tabi 
Signed-off-by: Hanjun Guo 
Signed-off-by: Will Deacon

ACPI / table: Always count matched and successfully parsed entries

2014-11-27T01:07:41+00:00

acpi_parse_entries() allows to traverse all available table entries (aka
subtables) by passing max_entries parameter equal to 0, but since its count
variable is only incremented if max_entries is not 0, the function always
returns 0 for max_entries equal to 0.  It would be more useful if it returned
the number of entries matched instead, so make it increment count in that
case too.

Acked-by: Grant Likely 
Signed-off-by: Tomasz Nowicki 
Signed-off-by: Hanjun Guo 
Signed-off-by: Rafael J. Wysocki

ACPI / table: Add new function to get table entries

2014-11-27T01:06:17+00:00

The acpi_table_parse() function has a callback that
passes a pointer to a table_header. Add a new function
which takes this pointer and parses its entries. This
eliminates the need to re-traverse all the tables for
each call. e.g. as in acpi_table_parse_madt() which is
normally called after acpi_table_parse().

Acked-by: Grant Likely 
Signed-off-by: Ashwin Chaugule 
Signed-off-by: Tomasz Nowicki 
Signed-off-by: Hanjun Guo 
Signed-off-by: Rafael J. Wysocki

ACPI: use kstrto() instead of simple_strto()

2014-06-17T12:01:56+00:00

simple_strto*() are obsolete; use kstrto*() instead. Add proper error
checking.

Signed-off-by: Christoph Jaeger 
Acked-by: David Rientjes 
Signed-off-by: Rafael J. Wysocki

ACPI: Fix x86 regression related to early mapping size limitation

2014-05-31T22:20:52+00:00

The following warning message is triggered:
 WARNING: CPU: 0 PID: 0 at mm/early_ioremap.c:136 __early_ioremap+0x11f/0x1f2()
 Modules linked in:
 CPU: 0 PID: 0 Comm: swapper Not tainted 3.15.0-rc1-00017-g86dfc6f3-dirty #298
 Hardware name: Intel Corporation S2600CP/S2600CP, BIOS SE5C600.86B.99.99.x036.091920111209 09/19/2011
  0000000000000009 ffffffff81b75c40 ffffffff817c627b 0000000000000000
  ffffffff81b75c78 ffffffff81067b5d 000000000000007b 8000000000000563
  00000000b96b20dc 0000000000000001 ffffffffff300e0c ffffffff81b75c88
 Call Trace:
  [] dump_stack+0x45/0x56
  [] warn_slowpath_common+0x7d/0xa0
  [] warn_slowpath_null+0x1a/0x20
  [] __early_ioremap+0x11f/0x1f2
  [] early_ioremap+0x13/0x15
  [] __acpi_map_table+0x13/0x18
  [] acpi_os_map_memory+0x26/0x14e
  [] acpi_tb_acquire_table+0x42/0x70
  [] acpi_tb_validate_table+0x27/0x37
  [] acpi_tb_verify_table+0x22/0xd8
  [] acpi_tb_install_non_fixed_table+0x60/0x1c9
  [] acpi_tb_parse_root_table+0x218/0x26a
  [] ? early_idt_handlers+0x120/0x120
  [] acpi_initialize_tables+0x57/0x59
  [] acpi_table_init+0x1b/0x99
  [] acpi_boot_table_init+0x1e/0x85
  [] setup_arch+0x99d/0xcc6
  [] ? early_idt_handlers+0x120/0x120
  [] start_kernel+0x8b/0x415
  [] ? early_idt_handlers+0x120/0x120
  [] x86_64_start_reservations+0x2a/0x2c
  [] x86_64_start_kernel+0x13e/0x14d
 ---[ end trace 11ae599a1898f4e7 ]---
when installing the following table during early stage:
 ACPI: SSDT 0x00000000B9638018 07A0C4 (v02 INTEL  S2600CP  00004000 INTL 20100331)
The regression is caused by the size limitation of the x86 early IO mapping.

The root cause is:
 1. ACPICA doesn't split IO memory mapping and table mapping;
 2. Linux x86 OSL implements acpi_os_map_memory() using a size limited fix-map
    mechanism during early boot stage, which is more suitable for only IO
    mappings.

This patch fixes this issue by utilizing acpi_gbl_verify_table_checksum to
disable the table mapping during early stage and enabling it again for the
late stage. In this way, the normal code path is not affected. Then after
the code related to the root cause is cleaned up, the early checksum
verification can be easily re-enabled.

A new boot parameter - acpi_force_table_verification is introduced for
the platforms that require the checksum verification to stop loading bad
tables.

This fix also covers the checksum verification for the table overrides. Now
large tables can also be overridden using the initrd override mechanism.

Signed-off-by: Lv Zheng 
Reported-and-tested-by: Yuanhan Liu 
Signed-off-by: Rafael J. Wysocki

ACPI / tables: Replace printk with pr_*

2014-03-02T00:34:16+00:00

This patch just does some cleanup to replace printk with pr_*,
and introduces pr_fmt() to remove all PREFIXs in tables.c,
no functional change.

Signed-off-by: Hanjun Guo 
Signed-off-by: Rafael J. Wysocki

ACPI / tables: Return proper error codes from acpi_table_parse() and fix comment.

2014-01-06T11:33:06+00:00

The comment about return value of acpi_table_parse() is incorrect.
This patch fix it.

Since all callers only check if the function succeeded or not, this
patch simplifies the semantics by returning -errno for all failure
cases. This will also simply the comment.

As suggested by Toshi Kani , also change the stub
in linux/acpi.h to return -ENODEV.

Signed-off-by: Tang Chen 
Signed-off-by: Rafael J. Wysocki

ACPI / tables: Check if id is NULL in acpi_table_parse()

2014-01-06T11:33:05+00:00

strncmp() does not check if the params are NULL. In acpi_table_parse(),
if @id is NULL, the kernel will panic.

Signed-off-by: Tang Chen 
Acked-by: Toshi Kani 
Signed-off-by: Rafael J. Wysocki

ACPI / table: Replace '1' with specific error return values

2013-12-07T00:31:59+00:00

After commit 7f8f97c3cc (ACPI: acpi_table_parse() now returns
success/fail, not count), acpi_table_parse() returns '1' when it is
unable to find the table, but it should return a negative error code
in that case.  Make it return -ENODEV instead.

Fix the same problem in acpi_table_init() analogously.

Signed-off-by: Hanjun Guo 
[rjw: Subject and changelog]
Signed-off-by: Rafael J. Wysocki