linux-stable.git/crypto/drbg.c, branch linux-3.18.y

Merge git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6

2014-09-05T08:11:43+00:00

Merging the crypto tree for 3.17 in order to resolve the conflict
on the 32-bit DRBG overflow fix.

crypto: drbg - remove check for uninitialized DRBG handle

2014-09-05T07:56:43+00:00

The drbg_healthcheck() contained a test to call the DRBG with an
uninitialized DRBG cipher handle. As this is an inappropriate use of the
kernel crypto API to try to generate random numbers before
initialization, checks verifying for an initialized DRBG have been
removed in previous patches.

Now, the drbg_healthcheck test must also be removed.

Changes V2: Added patch marker to email subject line.

Signed-off-by: Stephan Mueller 
Signed-off-by: Herbert Xu

crypto: drbg - fix sparse warning for cpu_to_be[32|64]

2014-08-26T07:33:28+00:00

The sparse tool complained that the cpu_to_be[32|64] functions return
__be[32|64] instead of __u32 or __u64. The patch replaces the __u32 and
__u64 with __be32 and __be64.

Reported-by: kbuild test robot 
Signed-off-by: Stephan Mueller 
Signed-off-by: Herbert Xu

crypto: drbg - remove unnecessary sanity check for shadow state

2014-08-25T12:34:14+00:00

During creation of the DRBG shadow state, it is ensured that the DRBG
state structure is already allocated. Thus, a sanity check for verifying
that the structure is allocated is removed.

Signed-off-by: Stephan Mueller 
Signed-off-by: Herbert Xu

crypto: drbg - remove configuration of fixed values

2014-08-25T12:34:12+00:00

SP800-90A mandates several hard-coded values. The old drbg_cores allows
the setting of these values per DRBG implementation. However, due to the
hard requirement of SP800-90A, these values are now returned globally
for each DRBG.

The ability to set such values per DRBG is therefore removed.

Signed-off-by: Stephan Mueller 
Signed-off-by: Herbert Xu

crypto: drbg - remove unnecessary sanity checks

2014-08-25T12:34:11+00:00

The drbg_make_shadow function contains sanity checks which are not
needed as the function is invoked at times where it is ensured that the
checked-for variables are available.

Signed-off-by: Stephan Mueller 
Signed-off-by: Herbert Xu

crypto: drbg - use kmalloc instead of kzalloc for V and C

2014-08-25T12:34:11+00:00

When allocating V, C, the zeroization is only needed when
allocating a new instance of the DRBG, i.e. when performing an
initial seeding. For all other allocations, the memcpy implemented in
drbg_copy_drbg ensures that the memory is filled with the correct
information.

Signed-off-by: Stephan Mueller 
Signed-off-by: Herbert Xu

crypto: drbg - remove superflowous memset(0)

2014-08-25T12:34:10+00:00

Remove memset(0) which is not needed due to the kzalloc of the memory.

Signed-off-by: Stephan Mueller 
Signed-off-by: Herbert Xu

crypto: drbg - remove superflowous checks

2014-08-25T12:34:09+00:00

The crypto_init and crypto_fini functions are always implemented. Thus,
there is no need for a protecting check.

Signed-off-by: Stephan Mueller 
Signed-off-by: Herbert Xu

crypto: drbg - kzfree does not need a check for NULL pointer

2014-08-25T12:34:09+00:00

The kzfree function already performs the NULL pointer check. Therefore,
the DRBG code does not need to implement such check.

Signed-off-by: Stephan Mueller 
Signed-off-by: Herbert Xu