linux-stable.git/crypto/ablkcipher.c, branch v3.2.99

crypto: {blk,giv}cipher: Set has_setkey

2016-04-01T00:54:31+00:00

Commit a1383cd86a06 ("crypto: skcipher - Add crypto_skcipher_has_setkey")
was incorrectly backported to the 3.2.y and 3.16.y stable branches.
We need to set ablkcipher_tfm::has_setkey in the
crypto_init_blkcipher_ops_async() and crypto_init_givcipher_ops()
functions as well as crypto_init_ablkcipher_ops().

Signed-off-by: Ben Hutchings

crypto: skcipher - Add crypto_skcipher_has_setkey

2016-02-13T10:34:12+00:00

commit a1383cd86a062fc798899ab20f0ec2116cce39cb upstream.

This patch adds a way for skcipher users to determine whether a key
is required by a transform.

Signed-off-by: Herbert Xu 
[bwh: Backported to 3.2: add to ablkcipher API instead]
Signed-off-by: Ben Hutchings

crypto: skcipher - Copy iv from desc even for 0-len walks

2016-01-22T21:40:03+00:00

commit 70d906bc17500edfa9bdd8c8b7e59618c7911613 upstream.

Some ciphers actually support encrypting zero length plaintexts. For
example, many AEAD modes support this. The resulting ciphertext for
those winds up being only the authentication tag, which is a result of
the key, the iv, the additional data, and the fact that the plaintext
had zero length. The blkcipher constructors won't copy the IV to the
right place, however, when using a zero length input, resulting in
some significant problems when ciphers call their initialization
routines, only to find that the ->iv parameter is uninitialized. One
such example of this would be using chacha20poly1305 with a zero length
input, which then calls chacha20, which calls the key setup routine,
which eventually OOPSes due to the uninitialized ->iv member.

Signed-off-by: Jason A. Donenfeld 
Signed-off-by: Herbert Xu 
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings

crypto: api - Only abort operations on fatal signal

2015-11-17T15:54:44+00:00

commit 3fc89adb9fa4beff31374a4bf50b3d099d88ae83 upstream.

Currently a number of Crypto API operations may fail when a signal
occurs.  This causes nasty problems as the caller of those operations
are often not in a good position to restart the operation.

In fact there is currently no need for those operations to be
interrupted by user signals at all.  All we need is for them to
be killable.

This patch replaces the relevant calls of signal_pending with
fatal_signal_pending, and wait_for_completion_interruptible with
wait_for_completion_killable, respectively.

Signed-off-by: Herbert Xu 
[bwh: Backported to 3.2: drop change to crypto_user_skcipher_alg(), which
 we don't have]
Signed-off-by: Ben Hutchings

crypto: user - fix info leaks in report API

2013-03-20T15:03:37+00:00

commit 9a5467bf7b6e9e02ec9c3da4e23747c05faeaac6 upstream.

Three errors resulting in kernel memory disclosure:

1/ The structures used for the netlink based crypto algorithm report API
are located on the stack. As snprintf() does not fill the remainder of
the buffer with null bytes, those stack bytes will be disclosed to users
of the API. Switch to strncpy() to fix this.

2/ crypto_report_one() does not initialize all field of struct
crypto_user_alg. Fix this to fix the heap info leak.

3/ For the module name we should copy only as many bytes as
module_name() returns -- not as much as the destination buffer could
hold. But the current code does not and therefore copies random data
from behind the end of the module name, as the module name is always
shorter than CRYPTO_MAX_ALG_NAME.

Also switch to use strncpy() to copy the algorithm's name and
driver_name. They are strings, after all.

Signed-off-by: Mathias Krause 
Cc: Steffen Klassert 
Signed-off-by: Herbert Xu 
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings

crypto: algapi - Fix build problem with NET disabled

2011-11-10T22:57:06+00:00

The report functions use NLA_PUT so we need to ensure that NET
is enabled.

Reported-by: Luis Henriques 
Signed-off-by: Herbert Xu

crypto: Add userspace report for givcipher type algorithms

2011-10-21T12:24:05+00:00

Signed-off-by: Steffen Klassert 
Signed-off-by: Herbert Xu

crypto: Add userspace report for ablkcipher type algorithms

2011-10-21T12:24:05+00:00

Signed-off-by: Steffen Klassert 
Signed-off-by: Herbert Xu

crypto: skcipher - remove redundant NULL check

2011-01-29T04:09:43+00:00

Signed-off-by: Davidlohr Bueso 
Acked-by: David S. Miller 
Signed-off-by: Herbert Xu

crypto: skcipher - avoid NULL dereference

2010-06-23T10:01:45+00:00

Stanse found a potential NULL dereference in ablkcipher_next_slow.
Even though kmalloc fails, its retval is dereferenced later. Return
from that function properly earlier.

Signed-off-by: Jiri Slaby 
Acked-by: David S. Miller 
Signed-off-by: Herbert Xu