linux-stable.git/block/sed-opal.c, branch v4.14.331

block: sed-opal: kmalloc the cmd/resp buffers

2022-11-25T16:36:49+00:00

[ Upstream commit f829230dd51974c1f4478900ed30bb77ba530b40 ]

In accordance with [1] the DMA-able memory buffers must be
cacheline-aligned otherwise the cache writing-back and invalidation
performed during the mapping may cause the adjacent data being lost. It's
specifically required for the DMA-noncoherent platforms [2]. Seeing the
opal_dev.{cmd,resp} buffers are implicitly used for DMAs in the NVME and
SCSI/SD drivers in framework of the nvme_sec_submit() and sd_sec_submit()
methods respectively they must be cacheline-aligned to prevent the denoted
problem. One of the option to guarantee that is to kmalloc the buffers
[2]. Let's explicitly allocate them then instead of embedding into the
opal_dev structure instance.

Note this fix was inspired by the commit c94b7f9bab22 ("nvme-hwmon:
kmalloc the NVME SMART log buffer").

[1] Documentation/core-api/dma-api.rst
[2] Documentation/core-api/dma-api-howto.rst

Fixes: 455a7b238cd6 ("block: Add Sed-opal library")
Signed-off-by: Serge Semin 
Reviewed-by: Christoph Hellwig 
Link: https://lore.kernel.org/r/20221107203944.31686-1-Sergey.Semin@baikalelectronics.ru
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

block: sed-opal: fix IOC_OPAL_ENABLE_DISABLE_MBR

2019-05-31T13:47:29+00:00

[ Upstream commit 78bf47353b0041865564deeed257a54f047c2fdc ]

The implementation of IOC_OPAL_ENABLE_DISABLE_MBR handled the value
opal_mbr_data.enable_disable incorrectly: enable_disable is expected
to be one of OPAL_MBR_ENABLE(0) or OPAL_MBR_DISABLE(1). enable_disable
was passed directly to set_mbr_done and set_mbr_enable_disable where
is was interpreted as either OPAL_TRUE(1) or OPAL_FALSE(0). The end
result was that calling IOC_OPAL_ENABLE_DISABLE_MBR with OPAL_MBR_ENABLE
actually disabled the shadow MBR and vice versa.

This patch adds correct conversion from OPAL_MBR_DISABLE/ENABLE to
OPAL_FALSE/TRUE. The change affects existing programs using
IOC_OPAL_ENABLE_DISABLE_MBR but this is typically used only once when
setting up an Opal drive.

Acked-by: Jon Derrick 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Scott Bauer 
Signed-off-by: David Kozub 
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin

block: sed-opal: Fix a couple off by one bugs

2018-08-24T11:09:03+00:00

[ Upstream commit ce042c183bcb94eb2919e8036473a1fc203420f9 ]

resp->num is the number of tokens in resp->tok[].  It gets set in
response_parse().  So if n == resp->num then we're reading beyond the
end of the data.

Fixes: 455a7b238cd6 ("block: Add Sed-opal library")
Reviewed-by: Scott Bauer 
Tested-by: Scott Bauer 
Signed-off-by: Dan Carpenter 
Signed-off-by: Jens Axboe 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled

2017-09-11T15:45:52+00:00

Users who are booting off their Opal enabled drives are having
issues when they have a shadow MBR set up after s3/resume cycle.
When the Drive has a shadow MBR setup the MBRDone flag is set to
false upon power loss (S3/S4/S5). When the MBRDone flag is false
I/O to LBA 0 -> LBA_END_MBR are remapped to the shadow mbr
of the drive. If the drive contains useful data in the 0 -> end_mbr
range upon s3 resume the user can never get to that data as the
drive will keep remapping it to the MBR. To fix this when we unlock
on S3 resume, we need to tell the drive that we're done with the
shadow mbr (even though we didnt use it) by setting true to MBRDone.
This way the drive will stop the remapping and the user can access
their data.

Acked-by Jon Derrick: 
Signed-off-by: Scott Bauer 
Signed-off-by: Jens Axboe

block: sed-opal: Tone down all the pr_* to debugs

2017-04-07T20:24:16+00:00

Lets not flood the kernel log with messages unless
the user requests so.

Signed-off-by: Scott Bauer 
Signed-off-by: Jens Axboe

block/sed-opal: fix spelling mistake: "Lifcycle" -> "Lifecycle"

2017-03-30T15:22:53+00:00

trivial fix to spelling mistake in pr_err error message

Signed-off-by: Colin Ian King 
Signed-off-by: Jens Axboe

block/sed: Fix opal user range check and unused variables

2017-03-08T16:56:12+00:00

Fixes check that the opal user is within the range, and cleans up unused
method variables.

Signed-off-by: Jon Derrick 
Reviewed-by: Scott Bauer 
Signed-off-by: Jens Axboe

block/sed-opal: Propagate original error message to userland.

2017-02-23T18:55:44+00:00

During an error on a comannd, ex: user provides wrong pw to unlock
range, we will gracefully terminate the opal session. We want to
propagate the original error to userland instead of the result of
the session termination, which is almost always a success.

Signed-off-by: Scott Bauer 
Signed-off-by: Jens Axboe

block/sed-opal: Introduce free_opal_dev to free the structure and clean up state

2017-02-23T18:55:41+00:00

Before we free the opal structure we need to clean up any saved
locking ranges that the user had told us to unlock from a suspend.

Signed-off-by: Scott Bauer 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block/sed: Embed function data into the function sequence

2017-02-22T18:54:49+00:00

By embedding the function data with the function sequence, we can
eliminate the external function data and state variable code. It also
made obvious some other small cleanups.

Signed-off-by: Jon Derrick 
Reviewed-by: Scott Bauer 
Signed-off-by: Jens Axboe