linux-stable.git/block/sed-opal.c, branch linux-5.2.y

block: switch all files cleared marked as GPLv2 to SPDX tags

2019-04-30T22:11:57+00:00

All these files have some form of the usual GPLv2 boilerplate.  Switch
them to use SPDX tags instead.

Reviewed-by: Chaitanya Kulkarni 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: sed-opal: rename next to execute_steps

2019-04-06T17:09:13+00:00

As the function is responsible for executing the individual steps supplied
in the steps argument, execute_steps is a more descriptive name than the
rather generic next.

Signed-off-by: David Kozub 
Reviewed-by: Scott Bauer 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Jon Derrick 
Signed-off-by: Jens Axboe

block: sed-opal: don't repeat opal_discovery0 in each steps array

2019-04-06T17:09:13+00:00

Originally each of the opal functions that call next include
opal_discovery0 in the array of steps. This is superfluous and
can be done always inside next.

Acked-by: Jon Derrick 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Scott Bauer 
Signed-off-by: David Kozub 
Signed-off-by: Jens Axboe

block: sed-opal: pass steps via argument rather than via opal_dev

2019-04-06T17:09:13+00:00

The steps argument is only read by the next function, so it can
be passed directly as an argument rather than via opal_dev.

Normally, the steps is an array on the stack, so the pointer stops
being valid then the function that set opal_dev.steps returns.
If opal_dev.steps was not set to NULL before return it would become
a dangling pointer. When the steps are passed as argument this
becomes easier to see and more difficult to misuse.

Acked-by: Jon Derrick 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Scott Bauer 
Signed-off-by: David Kozub 
Signed-off-by: Jens Axboe

block: sed-opal: use named Opal tokens instead of integer literals

2019-04-06T17:09:13+00:00

Replace integer literals by Opal tokens defined in opal_proto.h where
possible.

Reviewed-by: Christoph Hellwig 
Acked-by: Jon Derrick 
Reviewed-by: Scott Bauer 
Signed-off-by: David Kozub 
Signed-off-by: Jens Axboe

block: sed-opal: unify retrieval of table columns

2019-04-06T17:09:13+00:00

Instead of having multiple places defining the same argument list to get
a specific column of a sed-opal table, provide a generic version and
call it from those functions.

Co-authored-by: David Kozub 
Signed-off-by: Jonas Rabenstein 
Signed-off-by: David Kozub 
Reviewed-by: Scott Bauer 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Jon Derrick 
Signed-off-by: Jens Axboe

block: sed-opal: add token for OPAL_LIFECYCLE

2019-04-06T17:09:13+00:00

Define OPAL_LIFECYCLE token and use it instead of literals in
get_lsp_lifecycle.

Acked-by: Jon Derrick 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Scott Bauer 
Signed-off-by: David Kozub 
Signed-off-by: Jens Axboe

block: sed-opal: split generation of bytestring header and content

2019-04-06T17:09:12+00:00

Split the header generation from the (normal) memcpy part if a
bytestring is copied into the command buffer. This allows in-place
generation of the bytestring content. For example, copy_from_user may be
used without an intermediate buffer.

Signed-off-by: Jonas Rabenstein 
Signed-off-by: David Kozub 
Reviewed-by: Scott Bauer 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Jon Derrick 
Signed-off-by: Jens Axboe

block: sed-opal: print failed function address

2019-04-06T17:09:12+00:00

Add function address (and if available its symbol) to the message if a
step function fails.

Signed-off-by: Jonas Rabenstein 
Signed-off-by: David Kozub 
Reviewed-by: Scott Bauer 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Jon Derrick

block: sed-opal: reuse response_get_token to decrease code duplication

2019-04-06T17:09:12+00:00

response_get_token had already been in place, its functionality had
been duplicated within response_get_{u64,bytestring} with the same error
handling. Unify the handling by reusing response_get_token within the
other functions.

Co-authored-by: Jonas Rabenstein 
Signed-off-by: David Kozub 
Signed-off-by: Jonas Rabenstein 
Reviewed-by: Scott Bauer 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Jon Derrick 
Signed-off-by: Jens Axboe