linux-stable.git/block/partitions, branch v6.5.2

block/partition: fix signedness issue for Amiga partitions

2023-07-05T22:34:56+00:00

Making 'blk' sector_t (i.e. 64 bit if LBD support is active) fails the
'blk>0' test in the partition block loop if a value of (signed int) -1 is
used to mark the end of the partition block list.

Explicitly cast 'blk' to signed int to allow use of -1 to terminate the
partition block linked list.

Fixes: b6f3f28f604b ("block: add overflow checks for Amiga partition support")
Reported-by: Christian Zigotzky 
Link: https://lore.kernel.org/r/024ce4fa-cc6d-50a2-9aae-3701d0ebf668@xenosoft.de
Signed-off-by: Michael Schmitz 
Reviewed-by: Martin Steigerwald 
Tested-by: Christian Zigotzky 
Signed-off-by: Jens Axboe

block: add overflow checks for Amiga partition support

2023-06-20T20:28:17+00:00

The Amiga partition parser module uses signed int for partition sector
address and count, which will overflow for disks larger than 1 TB.

Use u64 as type for sector address and size to allow using disks up to
2 TB without LBD support, and disks larger than 2 TB with LBD. The RBD
format allows to specify disk sizes up to 2^128 bytes (though native
OS limitations reduce this somewhat, to max 2^68 bytes), so check for
u64 overflow carefully to protect against overflowing sector_t.

Bail out if sector addresses overflow 32 bits on kernels without LBD
support.

This bug was reported originally in 2012, and the fix was created by
the RDB author, Joanne Dow . A patch had been
discussed and reviewed on linux-m68k at that time but never officially
submitted (now resubmitted as patch 1 in this series).
This patch adds additional error checking and warning messages.

Reported-by: Martin Steigerwald 
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=43511
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Message-ID: <201206192146.09327.Martin@lichtvoll.de>
Cc:  # 5.2
Signed-off-by: Michael Schmitz 
Reviewed-by: Geert Uytterhoeven 
Reviewed-by: Christoph Hellwig 
Link: https://lore.kernel.org/r/20230620201725.7020-4-schmitzmic@gmail.com
Signed-off-by: Jens Axboe

block: fix signed int overflow in Amiga partition support

2023-06-20T20:28:17+00:00

The Amiga partition parser module uses signed int for partition sector
address and count, which will overflow for disks larger than 1 TB.

Use sector_t as type for sector address and size to allow using disks
up to 2 TB without LBD support, and disks larger than 2 TB with LBD.

This bug was reported originally in 2012, and the fix was created by
the RDB author, Joanne Dow . A patch had been
discussed and reviewed on linux-m68k at that time but never officially
submitted. This patch differs from Joanne's patch only in its use of
sector_t instead of unsigned int. No checking for overflows is done
(see patch 3 of this series for that).

Reported-by: Martin Steigerwald 
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=43511
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Message-ID: <201206192146.09327.Martin@lichtvoll.de>
Cc:  # 5.2
Signed-off-by: Michael Schmitz 
Tested-by: Martin Steigerwald 
Reviewed-by: Geert Uytterhoeven 
Reviewed-by: Christoph Hellwig 
Link: https://lore.kernel.org/r/20230620201725.7020-2-schmitzmic@gmail.com
Signed-off-by: Jens Axboe

block: add capacity validation in bdev_add_partition()

2023-06-20T18:50:51+00:00

In the function bdev_add_partition(),there is no check that the start
and end sectors exceed the size of the disk before calling add_partition.
When we call the block's ioctl interface directly to add a partition,
and the capacity of the disk is set to 0 by driver,the command will
continue to execute.

Signed-off-by: Min Li 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Damien Le Moal 
Link: https://lore.kernel.org/r/20230619091214.31615-1-min15.li@samsung.com
Signed-off-by: Jens Axboe

block: remove blk_drop_partitions

2023-06-05T16:53:04+00:00

There is only a single caller left, so fold the loop into that.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jan Kara 
Acked-by: Dave Chinner 
Reviewed-by: Dave Chinner 
Link: https://lore.kernel.org/r/20230601094459.1350643-9-hch@lst.de
Signed-off-by: Jens Axboe

block: delete partitions later in del_gendisk

2023-06-05T16:53:04+00:00

Delay dropping the block_devices for partitions in del_gendisk until
after the call to blk_mark_disk_dead, so that we can implementat
notification of removed devices in blk_mark_disk_dead.

This requires splitting a lower-level drop_partition helper out of
delete_partition and using that from del_gendisk, while having a
common loop for the whole device and partitions that calls
remove_inode_hash, fsync_bdev and __invalidate_device before the
call to blk_mark_disk_dead.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jan Kara 
Acked-by: Dave Chinner 
Reviewed-by: Dave Chinner 
Link: https://lore.kernel.org/r/20230601094459.1350643-8-hch@lst.de
Signed-off-by: Jens Axboe

block: unhash the inode earlier in delete_partition

2023-06-05T16:53:04+00:00

Move the call to remove_inode_hash to the beginning of delete_partition,
as we want to prevent opening a block_device that is about to be removed
ASAP.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jan Kara 
Acked-by: Dave Chinner 
Reviewed-by: Dave Chinner 
Link: https://lore.kernel.org/r/20230601094459.1350643-7-hch@lst.de
Signed-off-by: Jens Axboe

block: constify the whole_disk device_attribute

2023-05-30T17:12:43+00:00

The struct is never modified so it can be const.

Signed-off-by: Thomas Weißschuh 
Link: https://lore.kernel.org/r/20230419-const-partition-v3-4-4e14e48be367@weissschuh.net
Signed-off-by: Jens Axboe

block: constify struct part_attr_group

2023-05-30T17:12:43+00:00

The struct is never modified so it can be const.

Signed-off-by: Thomas Weißschuh 
Link: https://lore.kernel.org/r/20230419-const-partition-v3-3-4e14e48be367@weissschuh.net
Signed-off-by: Jens Axboe

block: constify struct part_type part_type

2023-05-30T17:12:43+00:00

The struct is never modified so it can be const.

Signed-off-by: Thomas Weißschuh 
Link: https://lore.kernel.org/r/20230419-const-partition-v3-2-4e14e48be367@weissschuh.net
Signed-off-by: Jens Axboe