linux-stable.git/block/ioctl.c, branch v5.12.2

block: return -EBUSY when there are open partitions in blkdev_reread_part

2021-04-21T16:49:37+00:00

The switch to go through blkdev_get_by_dev means we now ignore the
return value from bdev_disk_changed in __blkdev_get.  Add a manual
check to restore the old semantics.

Fixes: 4601b4b130de ("block: reopen the device in blkdev_reread_part")
Reported-by: Karel Zak 
Signed-off-by: Christoph Hellwig 
Link: https://lore.kernel.org/r/20210421160502.447418-1-hch@lst.de
Signed-off-by: Jens Axboe

block: reopen the device in blkdev_reread_part

2021-02-24T02:23:22+00:00

Historically the BLKRRPART ioctls called into the now defunct ->revalidate
method, which caused the sd driver to check if any media is present.
When the ->revalidate method was removed this revalidation was lost,
leading to lots of I/O errors when using the eject command.  Fix this by
reopening the device to rescan the partitions, and thus calling the
revalidation logic in the sd driver.

Fixes: 471bd0af544b ("sd: use bdev_check_media_change")
Reported--by: Tom Seewald 
Signed-off-by: Christoph Hellwig 
Tested-by: Tom Seewald 
Reviewed-by: Ming Lei 
Reviewed-by: Minwoo Im 
Signed-off-by: Jens Axboe

block: move the policy field to struct block_device

2020-12-01T21:53:40+00:00

Move the policy field to struct block_device and rename it to the
more descriptive bd_read_only.  Also turn the field into a bool as it
is used as such.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jan Kara 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Jens Axboe

block: remove i_bdev

2020-12-01T21:53:39+00:00

Switch the block device lookup interfaces to directly work with a dev_t
so that struct block_device references are only acquired by the
blkdev_get variants (and the blk-cgroup special case).  This means that
we now don't need an extra reference in the inode and can generally
simplify handling of struct block_device to keep the lookups contained
in the core block layer code.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jan Kara 
Reviewed-by: Hannes Reinecke 
Acked-by: Tejun Heo 
Acked-by: Coly Li 		[bcache]
Signed-off-by: Jens Axboe

block: remove a superflous check in blkpg_do_ioctl

2020-12-01T21:53:39+00:00

sector_t is now always a u64, so this check is not needed.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Jan Kara 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Acked-by: Tejun Heo 
Signed-off-by: Jens Axboe

block: remove __blkdev_driver_ioctl

2020-11-16T15:14:29+00:00

Just open code it in the few callers.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: remove set_device_ro

2020-11-16T15:14:29+00:00

Fold set_device_ro into its only remaining caller.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: don't call into the driver for BLKROSET

2020-11-16T15:14:29+00:00

Now that all drivers that want to hook into setting or clearing the
read-only flag use the set_read_only method, this code can be removed.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: add a new set_read_only method

2020-11-16T15:14:29+00:00

Add a new method to allow for driver-specific processing when setting or
clearing the block device read-only state.  This allows to replace the
cumbersome and error-prone override of the whole ioctl implementation.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: don't call into the driver for BLKFLSBUF

2020-11-16T15:14:29+00:00

BLKFLSBUF is entirely contained in the block core, and there is no
good reason to give the driver a hook into processing it.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe