linux-stable.git/block/bsg-lib.c, branch v5.0

bsg: move bsg-lib parts outside of request queue

2018-11-07T20:42:33+00:00

Get rid of the special bsg job fn and timeout handler, move them
into a private bsg_set instead.

Mostly from Christoph, with fixes for error handling and cleanups.

Reviewed-by: Hannes Reinecke 
Tested-by: Ming Lei 
Reviewed-by: Omar Sandoval 
Signed-off-by: Jens Axboe

block: kill legacy parts of timeout handling

2018-11-07T20:42:33+00:00

The only user of legacy timing now is BSG, which is invoked
from the mq timeout handler. Kill the legacy code, and rename
the q->rq_timed_out_fn to q->bsg_job_timeout_fn.

Reviewed-by: Hannes Reinecke 
Tested-by: Ming Lei 
Reviewed-by: Omar Sandoval 
Signed-off-by: Jens Axboe

bsg: convert to use blk-mq

2018-11-07T20:42:32+00:00

Requires a few changes to the FC transport class as well.

Cc: linux-scsi@vger.kernel.org
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Tested-by: Benjamin Block 
Tested-by: Ming Lei 
Reviewed-by: Omar Sandoval 
Signed-off-by: Jens Axboe

bsg: provide bsg_remove_queue() helper

2018-11-07T20:42:32+00:00

All drivers do unregister + cleanup, provide a helper for that.

Cc: linux-scsi@vger.kernel.org
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Christoph Hellwig 
Tested-by: Benjamin Block 
Tested-by: Ming Lei 
Reviewed-by: Omar Sandoval 
Signed-off-by: Jens Axboe

bsg: pass in desired timeout handler

2018-11-07T20:42:32+00:00

This will ease in the conversion to blk-mq, where we can't set
a timeout handler after queue init.

Cc: Johannes Thumshirn 
Cc: linux-scsi@vger.kernel.org
Reviewed-by: Hannes Reinecke 
Tested-by: Benjamin Block 
Tested-by: Ming Lei 
Reviewed-by: Omar Sandoval 
Signed-off-by: Jens Axboe

block/bsg-lib: use PTR_ERR_OR_ZERO to simplify the flow path

2018-08-01T15:13:03+00:00

Simplify the code by using the PTR_ERR_OR_ZERO, instead of the
open code. It is better.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: zhong jiang 
Signed-off-by: Jens Axboe

block: remove parent device reference from struct bsg_class_device

2018-05-29T19:00:25+00:00

Bsg holding a reference to the parent device may result in a crash if a
bsg file handle is closed after the parent device driver has unloaded.

Holding a reference is not really needed: the parent device must exist
between bsg_register_queue and bsg_unregister_queue.  Before the device
goes away the caller does blk_cleanup_queue so that all in-flight
requests to the device are gone and all new requests cannot pass beyond
the queue.  The queue itself is a refcounted object and it will stay
alive with a bsg file.

Based on analysis, previous patch and changelog from Anatoliy Glagolev.

Reported-by: Anatoliy Glagolev 
Reviewed-by: James E.J. Bottomley 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

bsg: split handling of SCSI CDBs vs transport requeues

2018-03-13T17:40:24+00:00

The current BSG design tries to shoe-horn the transport-specific
passthrough commands into the overall framework for SCSI passthrough
requests.  This has a couple problems:

 - each passthrough queue has to set the QUEUE_FLAG_SCSI_PASSTHROUGH flag
   despite not dealing with SCSI commands at all.  Because of that these
   queues could also incorrectly accept SCSI commands from in-kernel
   users or through the legacy SCSI_IOCTL_SEND_COMMAND ioctl.
 - the real SCSI bsg queues also incorrectly accept bsg requests of the
   BSG_SUB_PROTOCOL_SCSI_TRANSPORT type
 - the bsg transport code is almost unredable because it tries to reuse
   different SCSI concepts for its own purpose.

This patch instead adds a new bsg_ops structure to handle the two cases
differently, and thus solves all of the above problems.  Another side
effect is that the bsg-lib queues also don't need to embedd a
struct scsi_request anymore.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Jens Axboe

bsg-lib: remove bsg_job.req

2018-03-13T17:40:23+00:00

Users of the bsg-lib interface should only use the bsg_job data structure
and not know about implementation details of it.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Benjamin Block 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Jens Axboe

bsg-lib: introduce a timeout field in struct bsg_job

2018-03-13T17:40:21+00:00

The zfcp driver wants to know the timeout for a bsg job, so add a field
to struct bsg_job for it in preparation of not exposing the request
to the bsg-lib users.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Benjamin Block 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Jens Axboe