linux-stable.git/block/bsg-lib.c, branch linux-5.2.y

block: Fix bsg_setup_queue() kernel-doc header

2019-05-31T21:12:34+00:00

Document all bsg_setup_queue() arguments as required.

Fixes: aae3b069d5ce ("bsg: pass in desired timeout handler") # v5.0.
Reviewed-by: Chaitanya Kulkarni 
Signed-off-by: Bart Van Assche 
Signed-off-by: Jens Axboe

block: switch all files cleared marked as GPLv2 or later to SPDX tags

2019-04-30T22:11:59+00:00

All these files have some form of the usual GPLv2 or later boilerplate.
Switch them to use SPDX tags instead.

Reviewed-by: Chaitanya Kulkarni 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

scsi: bsg-lib: handle bidi requests without block layer help

2019-02-06T02:27:40+00:00

We can just stash away the second request in struct bsg_job instead of
using the block layer req->next_rq field, allowing for the eventual removal
of the latter.

Signed-off-by: Christoph Hellwig 
Acked-by: Jens Axboe 
Signed-off-by: Martin K. Petersen

bsg: move bsg-lib parts outside of request queue

2018-11-07T20:42:33+00:00

Get rid of the special bsg job fn and timeout handler, move them
into a private bsg_set instead.

Mostly from Christoph, with fixes for error handling and cleanups.

Reviewed-by: Hannes Reinecke 
Tested-by: Ming Lei 
Reviewed-by: Omar Sandoval 
Signed-off-by: Jens Axboe

block: kill legacy parts of timeout handling

2018-11-07T20:42:33+00:00

The only user of legacy timing now is BSG, which is invoked
from the mq timeout handler. Kill the legacy code, and rename
the q->rq_timed_out_fn to q->bsg_job_timeout_fn.

Reviewed-by: Hannes Reinecke 
Tested-by: Ming Lei 
Reviewed-by: Omar Sandoval 
Signed-off-by: Jens Axboe

bsg: convert to use blk-mq

2018-11-07T20:42:32+00:00

Requires a few changes to the FC transport class as well.

Cc: linux-scsi@vger.kernel.org
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Tested-by: Benjamin Block 
Tested-by: Ming Lei 
Reviewed-by: Omar Sandoval 
Signed-off-by: Jens Axboe

bsg: provide bsg_remove_queue() helper

2018-11-07T20:42:32+00:00

All drivers do unregister + cleanup, provide a helper for that.

Cc: linux-scsi@vger.kernel.org
Reviewed-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Christoph Hellwig 
Tested-by: Benjamin Block 
Tested-by: Ming Lei 
Reviewed-by: Omar Sandoval 
Signed-off-by: Jens Axboe

bsg: pass in desired timeout handler

2018-11-07T20:42:32+00:00

This will ease in the conversion to blk-mq, where we can't set
a timeout handler after queue init.

Cc: Johannes Thumshirn 
Cc: linux-scsi@vger.kernel.org
Reviewed-by: Hannes Reinecke 
Tested-by: Benjamin Block 
Tested-by: Ming Lei 
Reviewed-by: Omar Sandoval 
Signed-off-by: Jens Axboe

block/bsg-lib: use PTR_ERR_OR_ZERO to simplify the flow path

2018-08-01T15:13:03+00:00

Simplify the code by using the PTR_ERR_OR_ZERO, instead of the
open code. It is better.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: zhong jiang 
Signed-off-by: Jens Axboe

block: remove parent device reference from struct bsg_class_device

2018-05-29T19:00:25+00:00

Bsg holding a reference to the parent device may result in a crash if a
bsg file handle is closed after the parent device driver has unloaded.

Holding a reference is not really needed: the parent device must exist
between bsg_register_queue and bsg_unregister_queue.  Before the device
goes away the caller does blk_cleanup_queue so that all in-flight
requests to the device are gone and all new requests cannot pass beyond
the queue.  The queue itself is a refcounted object and it will stay
alive with a bsg file.

Based on analysis, previous patch and changelog from Anatoliy Glagolev.

Reported-by: Anatoliy Glagolev 
Reviewed-by: James E.J. Bottomley 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe