linux-stable.git/block/bio-integrity.c, branch linux-4.0.y

block: fix regression where bio_integrity_process uses wrong bio_vec iterator

2014-12-02T15:15:21+00:00

bio integrity handling is broken on a system with LVM layered atop a
DIF/DIX SCSI drive because device mapper clones the bio, modifies the
clone, and sends the clone to the lower layers for processing.
However, the clone bio has bi_vcnt == 0, which means that when the sd
driver calls bio_integrity_process to attach DIX data, the
for_each_segment_all() call (which uses bi_vcnt) returns immediately
and random garbage is sent to the disk on a disk write.  The disk of
course returns an error.

Therefore, teach bio_integrity_process() to use bio_for_each_segment()
to iterate the bio_vecs, since the per-bio iterator tracks which
bio_vecs are associated with that particular bio.  The integrity
handling code is effectively part of the "driver" (it's not the bio
owner), so it must use the correct iterator function.

v2: Fix a compiler warning about abandoned local variables.  This
patch supersedes "block: bio_integrity_process uses wrong bio_vec
iterator".  Patch applies against 3.18-rc6.

Signed-off-by: Darrick J. Wong 
Acked-by: Martin K. Petersen 
Signed-off-by: Jens Axboe

bio-integrity: remove the needless fail handle of bip_slab creating

2014-10-13T21:09:38+00:00

bip_slab is created with SLAB_PANIC, so the fail handler is unneeded.

Signed-off-by: Gu Zheng 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

block: Integrity checksum flag

2014-09-27T15:14:55+00:00

Make the choice of checksum a per-I/O property by introducing a flag
that can be inspected by the SCSI layer. There are several reasons for
this:

 1. It allows us to switch choice of checksum without unloading and
    reloading the HBA driver.

 2. During error recovery we need to be able to tell the HBA that
    checksums read from disk should not be verified and converted to IP
    checksums.

 3. For error injection purposes we need to be able to write a bad guard
    tag to storage. Since the storage device only supports T10 CRC we
    need to be able to disable IP checksum conversion on the HBA.

Signed-off-by: Martin K. Petersen 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Jens Axboe

block: Relocate bio integrity flags

2014-09-27T15:14:54+00:00

Move flags affecting the integrity code out of the bio bi_flags and into
the block integrity payload.

Signed-off-by: Martin K. Petersen 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Jens Axboe

block: Add prefix to block integrity profile flags

2014-09-27T15:14:51+00:00

Add a BLK_ prefix to the integrity profile flags. Also rename the flags
to be more consistent with the generate/verify terminology in the rest
of the integrity code.

Signed-off-by: Martin K. Petersen 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Jens Axboe

block: Clean up the code used to generate and verify integrity metadata

2014-09-27T15:14:51+00:00

Instead of the "operate" parameter we pass in a seed value and a pointer
to a function that can be used to process the integrity metadata. The
generation function is changed to have a return value to fit into this
scheme.

Signed-off-by: Martin K. Petersen 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Jens Axboe

block: Make protection interval calculation generic

2014-09-27T15:14:50+00:00

Now that the protection interval has been detached from the sector size
we need to be able to handle sizes that are different from 4K and
512. Make the interval calculation generic.

Signed-off-by: Martin K. Petersen 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Jens Axboe

block: Deprecate the use of the term sector in the context of block integrity

2014-09-27T15:14:50+00:00

The protection interval is not necessarily tied to the logical block
size of a block device. Stop using the terms "sector" and "sectors".

Going forward we will use the term "seed" to describe the initial
reference tag value for a given I/O. "Interval" will be used to describe
the portion of the data buffer that a given piece of protection
information is associated with.

Signed-off-by: Martin K. Petersen 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Jens Axboe

block: Remove bip_buf

2014-09-27T15:14:50+00:00

bip_buf is not really needed so we can remove it.

Signed-off-by: Martin K. Petersen 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Jens Axboe

block: Remove integrity tagging functions

2014-09-27T15:14:50+00:00

None of the filesystems appear interested in using the integrity tagging
feature. Potentially because very few storage devices actually permit
using the application tag space.

Remove the tagging functions.

Signed-off-by: Martin K. Petersen 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Jens Axboe