linux-stable.git/arch/x86/kernel/microcode_amd.c, branch v3.2

x86, microcode, AMD: Add microcode revision to /proc/cpuinfo

2011-10-19T14:07:30+00:00

Enable microcode revision output for AMD after 506ed6b53e00 ("x86,
intel: Output microcode revision in /proc/cpuinfo") did it for Intel.

Signed-off-by: Borislav Petkov

x86, microcode, AMD: Fix section header size check

2011-06-16T15:23:54+00:00

The ucode size check has to take the section header size into account
too when sanity checking the section length. Shorten and clarify define
names, while at it.

Caught-by: Ben Hutchings 
Link: http://lkml.kernel.org/r/1302752223.5282.674.camel@localhost
Signed-off-by: Borislav Petkov

x86, microcode, AMD: Correct buf references

2011-06-15T13:13:49+00:00

Both the equivalence table and the microcode patch types are u32. Access
them properly through the buf-ptr.

Signed-off-by: Borislav Petkov

x86, microcode, AMD: Fix signedness bug in generic_load_microcode()

2011-02-20T13:01:32+00:00

install_equiv_cpu_table() returns type int.  It uses negative
error codes so using an unsigned type breaks the error handling.

Signed-off-by: Dan Carpenter 
Acked-by: Borislav Petkov 
Cc: open list:AMD MICROCODE UPD... 
Cc: Andreas Herrmann 
LKML-Reference: <20110218091716.GA4384@bicker>
Signed-off-by: Ingo Molnar

x86, microcode, AMD: Extend ucode size verification

2011-02-10T11:24:03+00:00

The different families have a different max size for the ucode patch,
adjust size checking to the family we're running on. Also, do not
vzalloc the max size of the ucode but only the actual size that is
passed on from the firmware loader.

Signed-off-by: Borislav Petkov

x86, microcode, AMD: Cleanup dmesg output

2011-02-09T15:05:36+00:00

Unify pr_* to use pr_fmt, shorten messages, correct type formatting.

Signed-off-by: Borislav Petkov 
Acked-by: Andreas Herrmann

x86, microcode, AMD: Remove unneeded memset call

2011-02-09T15:05:35+00:00

collect_cpu_info_amd() clears its csig arg but this is done in the
microcode_core's collect_cpu_info() by clearing the embedding struct
ucode_cpu_info. Drop it.

Signed-off-by: Borislav Petkov 
Acked-by: Andreas Herrmann

x86, microcode, AMD: Simplify get_next_ucode

2011-02-09T15:05:34+00:00

Do not copy the section header but look at it directly through the
pointer. Also, make it return a ptr to a ucode header directly
thus dropping a bunch of unneeded casts. Finally, simplify
generic_load_microcode(), while at it.

Signed-off-by: Borislav Petkov 
Acked-by: Andreas Herrmann

x86, microcode, AMD: Simplify install_equiv_cpu_table

2011-02-09T15:05:33+00:00

There's no need to memcpy the ucode header in order to look at it only
in this function - use the original buffer instead. Also, fix return
type semantics by returning a negative value on error and a positive
otherwise.

Signed-off-by: Borislav Petkov 
Acked-by: Andreas Herrmann

x86, microcode, AMD: Release firmware on error

2011-02-09T15:05:32+00:00

When the ucode magic is wrong, for whatever reason, we don't release the
loaded firmware binary and its related resources. Make sure we do. Also,
fix function naming to fit this driver's convention and shorten variable
names.

Signed-off-by: Borislav Petkov 
Acked-by: Andreas Herrmann