linux-stable.git, branch v5.4.217

Linux 5.4.217

2022-10-07T07:16:57+00:00

Link: https://lore.kernel.org/r/20221005113210.255710920@linuxfoundation.org
Reviewed-by: Guenter Roeck 
Tested-by: Jon Hunter 
Tested-by: Linux Kernel Functional Testing 
Tested-by: Slade Watkins 
Tested-by: Allen Pais 
Signed-off-by: Greg Kroah-Hartman

docs: update mediator information in CoC docs

2022-10-07T07:16:57+00:00

commit 8bfdfa0d6b929ede7b6189e0e546ceb6a124d05d upstream.

Update mediator information in the CoC interpretation document.

Signed-off-by: Shuah Khan 
Link: https://lore.kernel.org/r/20220901212319.56644-1-skhan@linuxfoundation.org
Cc: stable@vger.kernel.org
Signed-off-by: Jonathan Corbet 
Signed-off-by: Greg Kroah-Hartman

Makefile.extrawarn: Move -Wcast-function-type-strict to W=1

2022-10-07T07:16:57+00:00

commit 2120635108b35ecad9c59c8b44f6cbdf4f98214e upstream.

We enable -Wcast-function-type globally in the kernel to warn about
mismatching types in function pointer casts. Compilers currently
warn only about ABI incompability with this flag, but Clang 16 will
enable a stricter version of the check by default that checks for an
exact type match. This will be very noisy in the kernel, so disable
-Wcast-function-type-strict without W=1 until the new warnings have
been addressed.

Cc: stable@vger.kernel.org
Link: https://reviews.llvm.org/D134831
Link: https://github.com/ClangBuiltLinux/linux/issues/1724
Suggested-by: Nathan Chancellor 
Signed-off-by: Sami Tolvanen 
Signed-off-by: Kees Cook 
Link: https://lore.kernel.org/r/20220930203310.4010564-1-samitolvanen@google.com
Signed-off-by: Greg Kroah-Hartman

Revert "drm/amdgpu: use dirty framebuffer helper"

2022-10-07T07:16:57+00:00

This reverts commit c89849ecfd2e10838b31c519c2a6607266b58f02 which is
commit 66f99628eb24409cb8feb5061f78283c8b65f820 upstream.

It is reported to cause problems on 5.4.y so it should be reverted for
now.

Reported-by: Shuah Khan 
Link: https://lore.kernel.org/r/7af02bc3-c0f2-7326-e467-02549e88c9ce@linuxfoundation.org
Cc: Hamza Mahfooz 
Cc: Alex Deucher 
Cc: Alex Deucher 
Cc: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

xfs: remove unused variable 'done'

2022-10-07T07:16:57+00:00

commit b3531f5fc16d4df2b12567bce48cd9f3ab5f9131 upstream.

fs/xfs/xfs_inode.c: In function 'xfs_itruncate_extents_flags':
fs/xfs/xfs_inode.c:1523:8: warning: unused variable 'done' [-Wunused-variable]

commit 4bbb04abb4ee ("xfs: truncate should remove
all blocks, not just to the end of the page cache")
left behind this, so remove it.

Fixes: 4bbb04abb4ee ("xfs: truncate should remove all blocks, not just to the end of the page cache")
Reported-by: Hulk Robot 
Reported-by: Stephen Rothwell 
Signed-off-by: YueHaibing 
Reviewed-by: Darrick J. Wong 
Signed-off-by: Darrick J. Wong 
Acked-by: Darrick J. Wong 
Signed-off-by: Chandan Babu R 
Signed-off-by: Greg Kroah-Hartman

xfs: fix uninitialized variable in xfs_attr3_leaf_inactive

2022-10-07T07:16:57+00:00

commit 54027a49938bbee1af62fad191139b14d4ee5cd2 upstream.

Dan Carpenter pointed out that error is uninitialized.  While there
never should be an attr leaf block with zero entries, let's not leave
that logic bomb there.

Fixes: 0bb9d159bd01 ("xfs: streamline xfs_attr3_leaf_inactive")
Reported-by: Dan Carpenter 
Signed-off-by: Darrick J. Wong 
Reviewed-by: Allison Collins 
Reviewed-by: Eric Sandeen 
Acked-by: Darrick J. Wong 
Signed-off-by: Chandan Babu R 
Signed-off-by: Greg Kroah-Hartman

xfs: streamline xfs_attr3_leaf_inactive

2022-10-07T07:16:57+00:00

commit 0bb9d159bd018b271e783d3b2d3bc82fa0727321 upstream.

Now that we know we don't have to take a transaction to stale the incore
buffers for a remote value, get rid of the unnecessary memory allocation
in the leaf walker and call the rmt_stale function directly.  Flatten
the loop while we're at it.

Signed-off-by: Darrick J. Wong 
Reviewed-by: Christoph Hellwig 
Acked-by: Darrick J. Wong 
Signed-off-by: Chandan Babu R 
Signed-off-by: Greg Kroah-Hartman

xfs: move incore structures out of xfs_da_format.h

2022-10-07T07:16:57+00:00

commit a39f089a25e75c3d17b955d8eb8bc781f23364f3 upstream.

Move the abstract in-memory version of various btree block headers
out of xfs_da_format.h as they aren't on-disk formats.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Darrick J. Wong 
Signed-off-by: Darrick J. Wong 
Acked-by: Darrick J. Wong 
Signed-off-by: Chandan Babu R 
Signed-off-by: Greg Kroah-Hartman

xfs: fix memory corruption during remote attr value buffer invalidation

2022-10-07T07:16:57+00:00

commit e8db2aafcedb7d88320ab83f1000f1606b26d4d7 upstream.

[Replaced XFS_IS_CORRUPT() calls with ASSERT() for 5.4.y backport]

While running generic/103, I observed what looks like memory corruption
and (with slub debugging turned on) a slub redzone warning on i386 when
inactivating an inode with a 64k remote attr value.

On a v5 filesystem, maximally sized remote attr values require one block
more than 64k worth of space to hold both the remote attribute value
header (64 bytes).  On a 4k block filesystem this results in a 68k
buffer; on a 64k block filesystem, this would be a 128k buffer.  Note
that even though we'll never use more than 65,600 bytes of this buffer,
XFS_MAX_BLOCKSIZE is 64k.

This is a problem because the definition of struct xfs_buf_log_format
allows for XFS_MAX_BLOCKSIZE worth of dirty bitmap (64k).  On i386 when we
invalidate a remote attribute, xfs_trans_binval zeroes all 68k worth of
the dirty map, writing right off the end of the log item and corrupting
memory.  We've gotten away with this on x86_64 for years because the
compiler inserts a u32 padding on the end of struct xfs_buf_log_format.

Fortunately for us, remote attribute values are written to disk with
xfs_bwrite(), which is to say that they are not logged.  Fix the problem
by removing all places where we could end up creating a buffer log item
for a remote attribute value and leave a note explaining why.  Next,
replace the open-coded buffer invalidation with a call to the helper we
created in the previous patch that does better checking for bad metadata
before marking the buffer stale.

Signed-off-by: Darrick J. Wong 
Reviewed-by: Christoph Hellwig 
Acked-by: Darrick J. Wong 
Signed-off-by: Chandan Babu R 
Signed-off-by: Greg Kroah-Hartman

xfs: refactor remote attr value buffer invalidation

2022-10-07T07:16:56+00:00

commit 8edbb26b06023de31ad7d4c9b984d99f66577929 upstream.

[Replaced XFS_IS_CORRUPT() calls with ASSERT() for 5.4.y backport]

Hoist the code that invalidates remote extended attribute value buffers
into a separate helper function.  This prepares us for a memory
corruption fix in the next patch.

Signed-off-by: Darrick J. Wong 
Reviewed-by: Christoph Hellwig 
Acked-by: Darrick J. Wong 
Signed-off-by: Chandan Babu R 
Signed-off-by: Greg Kroah-Hartman